Conversation
|
I think that both are good additions to the library, I really like the concept of Also, would it be possible to have the template inline in |
Owner
Author
|
Turns out the code as it is now has problem with types and/or lifetimes when actually using a template with join_html. Looking at how to fix it, may have to change the template function type and/or the ToHtml trait. |
90771bf to
f3cbe23
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A possible solution to #85 .
Questions / things to test:
join_htmlandjoin_to_htmlgood names for the functions?DoesIt does not, and would be rather hard to fix at the moment. But inline templates with arguments would be a separate issue that would fix it.join_htmlwork with inline subtemplates when used in templates?impl ToHtml, but currently bothjoin_htmlandjoin_to_htmlreturnsBox<dyn ToHtml>, as a trait function apparently cannot returnimpl Trait. They could also returnHtmlJoiner<...>, but then that class (which I consider an implementation detail) would have to be public, and the generic type arguments would be inconveniently long.join_htmlandjoin_to_htmlunderstandable?