Skip to content

Fix syntax for reading package metadata in GitHub Actions workflow#13

Merged
kasuken merged 1 commit into
mainfrom
githubaction
Sep 8, 2025
Merged

Fix syntax for reading package metadata in GitHub Actions workflow#13
kasuken merged 1 commit into
mainfrom
githubaction

Conversation

@kasuken
Copy link
Copy Markdown
Owner

@kasuken kasuken commented Sep 8, 2025

Correct the syntax for outputting package metadata in the GitHub Actions workflow to ensure proper variable assignment.

Copilot AI review requested due to automatic review settings September 8, 2025 15:33
@kasuken kasuken merged commit 56d688c into main Sep 8, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the syntax for reading package metadata in a GitHub Actions workflow to ensure proper variable assignment when outputting to $GITHUB_OUTPUT.

  • Adds proper double quotes around $GITHUB_OUTPUT variable references
  • Corrects the JavaScript expression for generating the VSIX filename to use string concatenation instead of template literals with console.log
  • Ensures consistent shell variable handling throughout the workflow

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

echo "vsix=$(node -p \"const p=require('./package.json'); console.log(`${p.name}-${p.version}.vsix`)\")" >> $GITHUB_OUTPUT
echo "version=$(node -p \"require('./package.json').version\")" >> "$GITHUB_OUTPUT"
echo "name=$(node -p \"require('./package.json').name\")" >> "$GITHUB_OUTPUT"
echo "vsix=$(node -p \"const p=require('./package.json'); p.name + '-' + p.version + '.vsix'\")" >> "$GITHUB_OUTPUT"
Copy link

Copilot AI Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node -p command expects a single expression, but this code declares a variable const p and then tries to use it in a separate expression. This will cause a syntax error. Use a single expression like node -p \"require('./package.json').name + '-' + require('./package.json').version + '.vsix'\" or wrap it in an IIFE: node -p \"(p => p.name + '-' + p.version + '.vsix')(require('./package.json'))\".

Suggested change
echo "vsix=$(node -p \"const p=require('./package.json'); p.name + '-' + p.version + '.vsix'\")" >> "$GITHUB_OUTPUT"
echo "vsix=$(node -p \"(p => p.name + '-' + p.version + '.vsix')(require('./package.json'))\")" >> "$GITHUB_OUTPUT"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants