Fix syntax for reading package metadata in GitHub Actions workflow#13
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the syntax for reading package metadata in a GitHub Actions workflow to ensure proper variable assignment when outputting to $GITHUB_OUTPUT.
- Adds proper double quotes around
$GITHUB_OUTPUTvariable references - Corrects the JavaScript expression for generating the VSIX filename to use string concatenation instead of template literals with console.log
- Ensures consistent shell variable handling throughout the workflow
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| echo "vsix=$(node -p \"const p=require('./package.json'); console.log(`${p.name}-${p.version}.vsix`)\")" >> $GITHUB_OUTPUT | ||
| echo "version=$(node -p \"require('./package.json').version\")" >> "$GITHUB_OUTPUT" | ||
| echo "name=$(node -p \"require('./package.json').name\")" >> "$GITHUB_OUTPUT" | ||
| echo "vsix=$(node -p \"const p=require('./package.json'); p.name + '-' + p.version + '.vsix'\")" >> "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
The node -p command expects a single expression, but this code declares a variable const p and then tries to use it in a separate expression. This will cause a syntax error. Use a single expression like node -p \"require('./package.json').name + '-' + require('./package.json').version + '.vsix'\" or wrap it in an IIFE: node -p \"(p => p.name + '-' + p.version + '.vsix')(require('./package.json'))\".
Suggested change
| echo "vsix=$(node -p \"const p=require('./package.json'); p.name + '-' + p.version + '.vsix'\")" >> "$GITHUB_OUTPUT" | |
| echo "vsix=$(node -p \"(p => p.name + '-' + p.version + '.vsix')(require('./package.json'))\")" >> "$GITHUB_OUTPUT" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the syntax for outputting package metadata in the GitHub Actions workflow to ensure proper variable assignment.