Skip to content

Fix syntax for reading package metadata in GitHub Actions workflow #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kasuken merged 1 commit into from
Sep 8, 2025
Merged

Fix syntax for reading package metadata in GitHub Actions workflow #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/publish-extension.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ jobs:
- name: Read package metadata
id: get_meta
run: |
echo "version=$(node -p \"require('./package.json').version\")" >> $GITHUB_OUTPUT
echo "name=$(node -p \"require('./package.json').name\")" >> $GITHUB_OUTPUT
echo "vsix=$(node -p \"const p=require('./package.json'); console.log(`${p.name}-${p.version}.vsix`)\")" >> $GITHUB_OUTPUT
echo "version=$(node -p \"require('./package.json').version\")" >> "$GITHUB_OUTPUT"
echo "name=$(node -p \"require('./package.json').name\")" >> "$GITHUB_OUTPUT"
echo "vsix=$(node -p \"const p=require('./package.json'); p.name + '-' + p.version + '.vsix'\")" >> "$GITHUB_OUTPUT"
Copy link

Copilot AI Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node -p command expects a single expression, but this code declares a variable const p and then tries to use it in a separate expression. This will cause a syntax error. Use a single expression like node -p \"require('./package.json').name + '-' + require('./package.json').version + '.vsix'\" or wrap it in an IIFE: node -p \"(p => p.name + '-' + p.version + '.vsix')(require('./package.json'))\".

Suggested change
echo "vsix=$(node -p \"const p=require('./package.json'); p.name + '-' + p.version + '.vsix'\")" >> "$GITHUB_OUTPUT"
echo "vsix=$(node -p \"(p => p.name + '-' + p.version + '.vsix')(require('./package.json'))\")" >> "$GITHUB_OUTPUT"

Copilot uses AI. Check for mistakes.

- name: Upload VSIX artifact (optional)
uses: actions/upload-artifact@v4
Expand Down
Loading