Remove redundant git checkout from pr-responder setup#705
Merged
Conversation
github-actions
bot
added
needs-triage
needs-priority
needs-actor
release-note-none
labels
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
gjkim42
reviewed
Mar 16, 2026
self-development/kelos-workers.yaml
Outdated
| - 3b. Create a commit that fixes the issue. | ||
| - 4b. Push your branch to origin kelos-task-{{.Number}}. | ||
| - 5b. Create a PR with labels "generated-by-kelos" and "ok-to-test" (use `gh pr create --label generated-by-kelos --label ok-to-test`), then /review it. If changes are needed, make them, commit and push, then /review again. Repeat until the review passes. | ||
| - 5b. Create a PR with labels "generated-by-kelos", "ok-to-test", and one `/kind` label (bug, cleanup, docs, or feature) matching the change type (use `gh pr create --label generated-by-kelos --label ok-to-test --label kind/<type>`), then /review it. If changes are needed, make them, commit and push, then /review again. Repeat until the review passes. |
Collaborator
There was a problem hiding this comment.
including /kind something handles it.
you don't have to do this. fix it and commit ammend it.
/kelos pick-up
Author
|
🤖 Kelos Task Status Task |
Kelos automatically checks out the branch specified in branch: "{{.Branch}}"
before the agent starts, making the explicit git checkout commands redundant.
This also eliminates the shell injection risk from unquoted template variables.
The /kind label change in kelos-workers.yaml is reverted as including /kind
in the PR body already handles adding the kind label automatically.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kelos-bot
bot
force-pushed
the
kelos-config-update-20260316-1800
branch
from
9f9dc1f to
eeb0621
Compare
kelos-bot
bot
changed the title
Author
|
🤖 Kelos Agent @gjkim42 Addressed the review feedback:
All CI checks pass (build, test, test-integration, verify, check-pr-labels, CLA). The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind cleanup
What this PR does / why we need it:
Removes redundant
git checkout {{.Branch}}commands from the pr-responder agent setup step. Kelos automatically checks out the branch specified inbranch: "{{.Branch}}"before the agent starts, making these explicit checkout commands unnecessary. Removing them also eliminates a shell injection risk from unquoted template variables.Which issue(s) this PR is related to:
N/A
Special notes for your reviewer:
The original PR also included a
/kindlabel change in kelos-workers.yaml, which was reverted per reviewer feedback — including/kind somethingin the PR body already handles adding the kind label.Does this PR introduce a user-facing change?