Skip to content

P0001 (accept + execute): completion claims require artifacts in definition-of-done#168

Merged
klappy merged 1 commit intomainfrom
claude/p0001-completion-requires-artifacts
May 5, 2026
Merged

P0001 (accept + execute): completion claims require artifacts in definition-of-done#168
klappy merged 1 commit intomainfrom
claude/p0001-completion-requires-artifacts

Conversation

@klappy
Copy link
Copy Markdown
Owner

@klappy klappy commented May 5, 2026

What this PR does

Combined acceptance + execution of promotion P0001 — aligns the canonical Definition of Done with the Validation Agent's already-enforced behavior.

Acceptance (1 file)

  • docs/promotions/P0001-completion-requires-artifacts.md
    • promotion_status: proposedaccepted
    • Tags array "proposed""accepted"
    • Status section header → accepted (2026-05-05)
    • Review Notes filled with operator decision

Execution (1 file, +3 lines net)

  • canon/constraints/definition-of-done.md ## Operating Constraints — two new MUST bullets:
    • MUST NOT mark a claim as verified without at least one artifact that demonstrates the claimed outcome
    • MUST return NEEDS_ARTIFACTS (not PASS) when a completion claim exists but the supporting evidence is absent
  • canon/constraints/definition-of-done.md ## Failure Modes — one new entry:
    • **"Unverified Completion"**: Accepting a "done" / "finished" / "shipped" claim without corresponding artifacts (screenshots, logs, links, command output). The validation pathway MUST return NEEDS_ARTIFACTS, not PASS

Why this matters

Per P0001's evidence section, the Validation Agent (infra/orchestrator/services/validation.js) already returns NEEDS_ARTIFACTS via determineVerdict() when claims have no matching artifacts. Until now this was enforced at code level only — Canon did not state the rule. After this merge, the constraint is citeable from oddkit_search and the Librarian, so future agents reading Definition of Done preflight see the rule explicitly.

Position in the 8-proposal sweep

# ID Status
1 P0009 PR #167 — open
2 P0001 this PR
3 P0008 next — fresh-validator DOLCHEO ledger convention
4-8 P0007, P0006, P0003, P0004, P0005 queued

DoD

  • Proposal frontmatter promotion_status flipped to accepted
  • Review Notes block filled
  • Canon edit text matches P0001 §"Proposed Language" verbatim
  • Insertion points match P0001 §"Section" (Operating Constraints + Failure Modes)
  • No other canon docs touched

Note

Low Risk
Low risk documentation-only change that tightens Definition of Done language and promotion status without affecting runtime behavior.

Overview
Updates the canon Definition of Done to explicitly require artifacts before marking completion claims as verified, and to mandate returning NEEDS_ARTIFACTS (not PASS) when evidence is missing.

Marks promotion P0001 as accepted by updating frontmatter/status and filling in review notes to record the decision and rationale.

Reviewed by Cursor Bugbot for commit d282da9. Bugbot is set up for automated code reviews on this repo. Configure here.

Acceptance:
- Flip docs/promotions/P0001 promotion_status: proposed -> accepted
- Update tags array ("proposed" -> "accepted")
- Fill Review Notes with operator decision (klappy, 2026-05-05)

Execution:
- canon/constraints/definition-of-done.md: append two MUST bullets to
  "## Operating Constraints" (no verified claim without artifact;
  return NEEDS_ARTIFACTS not PASS when evidence absent)
- canon/constraints/definition-of-done.md: append one entry to
  "## Failure Modes" ("Unverified Completion")

Aligns canon with the Validation Agent's existing enforcement
(infra/orchestrator/services/validation.js determineVerdict()).

Second of 8 stuck proposals being walked through to acceptance + execution.
Previous: P0009 (PR #167). Next in queue: P0008 (release-validation-gate
amendment for the validator-deliverable convention).
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Canon Quality — oddkit_audit

No dead klappy:// references or legacy link patterns found in writings/. 39 files scanned.

Spec: klappy://docs/oddkit/specs/oddkit-audit · Workflow: .github/workflows/canon-quality.yml · Run: #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants