Fix ModelMapper.processJarPackage breaking on paths containing '+'#4712
Draft
Fix ModelMapper.processJarPackage breaking on paths containing '+'#4712
Conversation
Agent-Logs-Url: https://github.com/kubernetes-client/java/sessions/251a25c1-d66c-4929-94c7-9fb3323acc89 Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Copilot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Copilot
AI
changed the title
[WIP] Fix ModelMapper.processJarPackage to handle '+' in paths
Fix ModelMapper.processJarPackage breaking on paths containing '+'
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ModelMapper.processJarPackageusedURLDecoder.decodeto extract the JAR file path from afile:URL.URLDecoderfollowsapplication/x-www-form-urlencodedsemantics where+→ space, corrupting paths with literal+characters. This causesinitModelMap()to fail silently, leaving the prebuilt model map empty. Manifests in Bazel 8 environments where canonical repo names use+(e.g.,rules_jvm_external++maven+maven/...client-java-api-26.0.0.jar).Changes
URLDecoder.decodewithURI.create(...).getPath()for thefile:JAR path case.URI.getPath()correctly decodes%XXsequences but treats+as a literal character — correct URL semantics.packageURL.getFile()post-processing forjar:/nested:cases — these already went throughJarURLConnectionand were unaffected.!separator in thefile:URL before callingsubstring.URLDecoderandStandardCharsets.