Skip to content

Fix ModelMapper.processJarPackage breaking on paths containing '+' #4712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −5
Draft

Fix ModelMapper.processJarPackage breaking on paths containing '+' #4712

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e6de96
Initial plan
Copilot Apr 22, 2026
23bb7ee
Fix ModelMapper.processJarPackage breaking on paths containing '+'
Copilot Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions util/src/main/java/io/kubernetes/client/util/ModelMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@
import java.net.JarURLConnection;
import java.net.URI;
import java.net.URL;
import java.net.URLDecoder;
import java.nio.charset.StandardCharsets;
import java.time.Duration;
import java.util.ArrayList;
import java.util.Enumeration;
Expand Down Expand Up @@ -493,16 +491,23 @@ private static List<String> getClassNamesFromPackage(ClassLoader classLoader, St
}

private static void processJarPackage(URL packageURL, String packageName, String pkg, ArrayList<String> names) throws IOException {
String jarFileName = URLDecoder.decode(packageURL.getFile(), StandardCharsets.UTF_8);
String jarFileName = packageURL.getFile();
JarFile jf = null;
// jar: client in repository; nested: client in a fat jar
if (jarFileName.startsWith("jar:") || jarFileName.startsWith("nested:")) {
jf = ((JarURLConnection) packageURL.openConnection()).getJarFile();
}
// file: client is a file in target (unit test)
if (jarFileName.startsWith("file:") ) {
jarFileName = jarFileName.substring(5, jarFileName.indexOf("!"));
jf = new JarFile(jarFileName);
int bangIndex = jarFileName.indexOf("!");
if (bangIndex < 0) {
logger.error("Loading classes from jar with error packageURL: {}", jarFileName);
return;
}
// Use URI.create to properly decode percent-encoded characters without converting + to space
// (URLDecoder.decode incorrectly converts + to space, breaking paths that contain literal +)
String filePart = jarFileName.substring(0, bangIndex);
jf = new JarFile(URI.create(filePart).getPath());
}
if (jf == null) {
logger.error("Loading classes from jar with error packageURL: {}", jarFileName);
Expand Down
Loading