feat: restructure ScanFailureOnFinishedMessage to embed armoapi-go Sc…

[kooomix]

…anFailureReport

Summary by CodeRabbit

Release Notes

• Chores

  • Updated Go tooling to version 1.24.1
  • Upgraded multiple dependencies to latest versions

• Improvements

  • Enhanced rate limiting capability with daily limit tracking

[coderabbitai]

Warning

Rate limit exceeded

@kooomix has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 9 minutes and 57 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ce940c66-d565-49bd-90d0-3ac996640122

📥 Commits

Reviewing files that changed from the base of the PR and between 87a5dd6 and c3fe9ce.

⛔ Files ignored due to path filters (1)

• go.sum is excluded by !**/*.sum

📒 Files selected for processing (1)

• go.mod

📝 Walkthrough

Walkthrough

Go language upgraded from 1.23.x to 1.24.1 with dependency version bumps. Scan failure type definitions removed from local scanfailure package and consolidated to import from armosec/armoapi-go. Added DailyLimit field to ScanFailureOnFinishedMessage.

Changes

Cohort / File(s)	Summary
Dependency Updates go.mod	Upgraded Go version to 1.24.1; bumped direct and indirect dependencies including armoapi-go, testify, OTEL modules, crypto, protobuf, and others to newer versions.
Scan Failure Type Consolidation pulsar/common/scanfailure/types.go, pulsar/common/systemhealth/datastructures.go	Deleted local type definitions (ScanFailureCase, WorkloadIdentifier, ScanFailureReport); updated systemhealth datastructures to import scanfailure types from armosec/armoapi-go instead of kubescape/messaging; added DailyLimit field to ScanFailureOnFinishedMessage.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• feat: add scan failure onFinish topic and message type #97 — Introduced original scanfailure types and ScanFailureOnFinishedMessage which are now being migrated to armosec/armoapi-go in this PR.

Suggested reviewers

• YakirOren
• bvolovat
• matthyx

Poem

🐰 Types were scattered, now they're one,
From messaging to API—migration's done!
Daily limits and imports aligned,
Go 1.24 lifts code to new design! 🎉

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: restructuring ScanFailureOnFinishedMessage to embed armoapi-go ScanFailureReport. It directly reflects the primary refactoring effort shown across multiple files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/SUB-7105-scan-failure-notification

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Summary:

• License scan: failure
• Credentials scan: skipped
• Vulnerabilities scan: skipped
• Unit test: success
• Go linting: success

[github-actions]

Summary:

• License scan: failure
• Credentials scan: skipped
• Vulnerabilities scan: skipped
• Unit test: success
• Go linting: success