Skip to content

add image override for Helm charts#85

Open
matthyx wants to merge 1 commit intomainfrom
add-image-override
Open

add image override for Helm charts#85
matthyx wants to merge 1 commit intomainfrom
add-image-override

Conversation

@matthyx
Copy link
Copy Markdown
Contributor

@matthyx matthyx commented Mar 27, 2026

Summary by CodeRabbit

  • Chores
    • Enhanced system and E2E test workflow to include additional component and container image metadata for improved test execution tracking.

Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 27, 2026

📝 Walkthrough

Walkthrough

Extended the workflow dispatch payload for E2E system tests by including component_name, image_name, and image_tag parameters. These fields are now forwarded to the downstream armosec/shared-workflows repository alongside existing chart metadata and configuration identifiers.

Changes

Cohort / File(s) Summary
Workflow Dispatch Payload Extension
.github/workflows/incluster-comp-pr-merged.yaml
Added three new fields to the repository dispatch payload: component_name from workflow inputs, image_name from workflow inputs, and image_tag from docker-build job outputs, enabling downstream workflows to access container image metadata.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • Run test from private repo #76: Modifies the same workflow to pass component and image metadata to downstream dispatches, extending dispatch payload logic for component identification.
  • run system test from private repo #75: Updates .github/workflows/incluster-comp-pr-merged.yaml dispatch and coordination logic, including correlation ID generation and E2E run monitoring alongside test dispatch improvements.
  • update kubescape cli e2e run from private repo #80: Modifies repository dispatch payload sent to armosec/shared-workflows, broadening test orchestration fields in similar dispatch workflows.

Suggested reviewers

  • Naor-Armo

Poem

🐰 A tiny change, but oh so fine,
Three new fields in the dispatch line!
Component names and images so bright,
Flow down the workflow with delight! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly reflects the main change: adding image override parameters (image_name and image_tag) to the workflow dispatch payload for Helm charts testing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-image-override

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/incluster-comp-pr-merged.yaml:
- Around line 291-293: The e2e-test-trigger dispatch payloads are inconsistent:
the dispatch in this workflow now includes client_payload fields component_name,
image_tag, and image_name while other dispatchers (e.g.,
kubescape-cli-e2e-tests.yaml) do not; pick one fix—either update every
e2e-test-trigger dispatcher to include the same three fields (component_name,
image_tag, image_name) so payloads are uniform, or modify the receiving reusable
workflow in armosec/shared-workflows (and its documented contract) to accept
optional/missing component_name/image_tag/image_name and provide sensible
defaults; locate the dispatch invocations and the receiver entrypoint (the
e2e-test-trigger workflow and the shared-workflows receiver) and implement the
chosen option so all dispatchers and the receiver agree on the schema.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1bf00e3f-329b-4117-84f9-ab958778b8c9

📥 Commits

Reviewing files that changed from the base of the PR and between 889c5f6 and 94f5a03.

📒 Files selected for processing (1)
  • .github/workflows/incluster-comp-pr-merged.yaml

Comment on lines +291 to +293
-f "client_payload[component_name]=${{ inputs.COMPONENT_NAME }}" \
-f "client_payload[image_tag]=${{ needs.docker-build.outputs.IMAGE_TAG_PRERELEASE }}" \
-f "client_payload[image_name]=${{ inputs.IMAGE_NAME }}"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Inspecting repository_dispatch payloads for e2e-test-trigger..."
rg -n -C3 'event_type="e2e-test-trigger"|client_payload\[(component_name|image_tag|image_name)\]' .github/workflows

echo
echo "Expected result:"
echo "- All e2e-test-trigger dispatchers include component_name/image_tag/image_name,"
echo "  OR receiver-side defaults are documented and implemented."

Repository: kubescape/workflows

Length of output: 2871


Resolve payload field inconsistency across e2e-test-trigger dispatchers before merging.

Lines 291–293 add component_name, image_tag, and image_name to the payload, but kubescape-cli-e2e-tests.yaml (line 141) dispatches the same event type without these fields. Either:

  • Update all e2e-test-trigger dispatchers to include all fields consistently, or
  • Ensure the receiver in armosec/shared-workflows has documented, implemented defaults for missing fields and can handle both payload schemas.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/incluster-comp-pr-merged.yaml around lines 291 - 293, The
e2e-test-trigger dispatch payloads are inconsistent: the dispatch in this
workflow now includes client_payload fields component_name, image_tag, and
image_name while other dispatchers (e.g., kubescape-cli-e2e-tests.yaml) do not;
pick one fix—either update every e2e-test-trigger dispatcher to include the same
three fields (component_name, image_tag, image_name) so payloads are uniform, or
modify the receiving reusable workflow in armosec/shared-workflows (and its
documented contract) to accept optional/missing
component_name/image_tag/image_name and provide sensible defaults; locate the
dispatch invocations and the receiver entrypoint (the e2e-test-trigger workflow
and the shared-workflows receiver) and implement the chosen option so all
dispatchers and the receiver agree on the schema.

@github-actions
Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

@matthyx matthyx requested a review from bvolovat March 31, 2026 09:14
@matthyx matthyx moved this to Needs Reviewer in KS PRs tracking Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs Reviewer

Development

Successfully merging this pull request may close these issues.

1 participant