Skip to content

add image override for Helm charts #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthyx wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add image override for Helm charts #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/incluster-comp-pr-merged.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,10 @@ jobs:
-f "client_payload[in_cluster_chart_branch]=${{ inputs.HELM_BRANCH }}" \
-f "client_payload[ks_branch]=release" \
-f "client_payload[charts_name]=kubescape-operator" \
-f "client_payload[charts_repo]=kubescape/helm-charts"
-f "client_payload[charts_repo]=kubescape/helm-charts" \
-f "client_payload[component_name]=${{ inputs.COMPONENT_NAME }}" \
-f "client_payload[image_tag]=${{ needs.docker-build.outputs.IMAGE_TAG_PRERELEASE }}" \
-f "client_payload[image_name]=${{ inputs.IMAGE_NAME }}"
Comment on lines +291 to +293
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Inspecting repository_dispatch payloads for e2e-test-trigger..."
rg -n -C3 'event_type="e2e-test-trigger"|client_payload\[(component_name|image_tag|image_name)\]' .github/workflows

echo
echo "Expected result:"
echo "- All e2e-test-trigger dispatchers include component_name/image_tag/image_name,"
echo "  OR receiver-side defaults are documented and implemented."

Repository: kubescape/workflows

Length of output: 2871

Resolve payload field inconsistency across e2e-test-trigger dispatchers before merging.

Lines 291–293 add component_name, image_tag, and image_name to the payload, but kubescape-cli-e2e-tests.yaml (line 141) dispatches the same event type without these fields. Either:

  • Update all e2e-test-trigger dispatchers to include all fields consistently, or
  • Ensure the receiver in armosec/shared-workflows has documented, implemented defaults for missing fields and can handle both payload schemas.
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/incluster-comp-pr-merged.yaml around lines 291 - 293, The
e2e-test-trigger dispatch payloads are inconsistent: the dispatch in this
workflow now includes client_payload fields component_name, image_tag, and
image_name while other dispatchers (e.g., kubescape-cli-e2e-tests.yaml) do not;
pick one fix—either update every e2e-test-trigger dispatcher to include the same
three fields (component_name, image_tag, image_name) so payloads are uniform, or
modify the receiving reusable workflow in armosec/shared-workflows (and its
documented contract) to accept optional/missing
component_name/image_tag/image_name and provide sensible defaults; locate the
dispatch invocations and the receiver entrypoint (the e2e-test-trigger workflow
and the shared-workflows receiver) and implement the chosen option so all
dispatchers and the receiver agree on the schema.


echo "Dispatch completed"

Expand Down
Loading