Fix fracture.cpp to run on GPUs and speed up fracture regression tests#335
Merged
alexholmes814 merged 5 commits intoJun 16, 2026
Merged
Conversation
… after MPI updates PR; now passes CUDA regression tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed bug that was not allowing fracture.cpp to run on GPUs. Modified fracture regression tests to run much faster on GPUs. In fracture.cpp there was a State.node.coords.update_device() causing a stale copy. This PR is intended just to fix fracture.cpp to run on GPUs and speed up fracture regression tests on GPUs.
After this PR, there will be a follow up PR for fracture to: parallelize parallel safe functions, refactor member functions to be free functions, and refactor most DCArrayKokkos to CArrayKokkos in fracture.cpp, etc. .
Type of change
Please select all relevant options
How Has This Been Tested?
Test Configuration:
Checklist: