Fix fracture.cpp to run on GPUs and speed up fracture regression tests

apps/multiphysics/regression_tests/standard_inputs/fracture_mode_1.yaml

@@ -1,10 +1,10 @@
 # num_dims: 3
 
 dynamic_options:
-  time_final: 4.0
-  dt_min: 1e-6
-  dt_max: 0.001
-  dt_start: 1.e-5
+  time_final: 1.5
+  dt_min: 1e-3
+  dt_max: 0.1
+  dt_start: 1.e-2
   cycle_stop: 300000
 
 
@@ -16,7 +16,7 @@ mesh_options:
 output_options:
   timer_output_level: thorough
   output_file_format: state
-  graphics_time_step: 2.0
+  graphics_time_step: 1.5
   # graphics_iteration_step: 10
 
 solver_options:
@@ -60,11 +60,11 @@ boundary_conditions:
         - 1 # z
         - 0.0 # hydro_bc_vel_0 
         - 0.0 # hydro_bc_vel_1 
-        - -5.0e-2 # hydro_bc_vel_2 
+        - -5.0e-7 # hydro_bc_vel_2 
         - 0.0 # t_start
-        - 4.0 # t_end
+        - 1.5 # t_end
 
-  # Tag z plane (top surface z=2 velocity in +z direction)
+  # Tag z plane (top surface z=0.2 velocity in +z direction)
   - boundary_condition:
       solver_id: 0
       surface:
@@ -77,9 +77,9 @@ boundary_conditions:
         - 1 # z
         - 0.0 # hydro_bc_vel_0 
         - 0.0 # hydro_bc_vel_1 
-        - 5.0e-2 # hydro_bc_vel_2 
+        - 5.0e-7 # hydro_bc_vel_2 
         - 0.0 # t_start 
-        - 4.0    # t_end
+        - 1.5    # t_end
 
 materials:
   - material:
@@ -109,10 +109,6 @@ materials:
           - 1.333 # q2ex
           - 0.1     # phi_min
           - 1.0   # phi_curl
-      eos_global_vars:
-          - 10 #1.666666666666667
-          - 1.0E-14
-          - 1.0
 
 regions:
   - region:
@@ -135,5 +131,4 @@ initial_conditions:
           type: cartesian
           u: 0.0
           v: 0.0
-          w: 0.0
-
+          w: 0.0

apps/multiphysics/regression_tests/standard_inputs/fracture_mode_2.yaml

@@ -1,10 +1,10 @@
 # num_dims: 3
 
 dynamic_options:
-  time_final: 4.0
-  dt_min: 1e-6
-  dt_max: 0.001
-  dt_start: 1.e-5
+  time_final: 1.5
+  dt_min: 1e-3
+  dt_max: 0.1
+  dt_start: 1.e-2
   cycle_stop: 300000
 
 
@@ -16,7 +16,7 @@ mesh_options:
 output_options:
   timer_output_level: thorough
   output_file_format: state
-  graphics_time_step: 2.0
+  graphics_time_step: 1.5
   # graphics_iteration_step: 10
 
 solver_options:
@@ -98,7 +98,7 @@ boundary_conditions:
         - 0.0 # hydro_bc_vel_1 
         - 0.0 # hydro_bc_vel_2 
         - 0.0 # t_start
-        - 4.0 # t_end
+        - 1.5 # t_end
 
   # Tag z plane (top surface z=2 velocity in +x direction)
   - boundary_condition:
@@ -115,7 +115,7 @@ boundary_conditions:
         - 0.0 # hydro_bc_vel_1 
         - 0.0 # hydro_bc_vel_2 
         - 0.0 # t_start 
-        - 4.0    # t_end
+        - 1.5    # t_end
 
 materials:
   - material:
@@ -145,10 +145,6 @@ materials:
           - 1.333 # q2ex
           - 0.1     # phi_min
           - 1.0   # phi_curl
-      eos_global_vars:
-          - 10 #1.666666666666667
-          - 1.0E-14
-          - 1.0
 
 regions:
   - region:
@@ -172,5 +168,4 @@ initial_conditions:
           type: cartesian
           u: 0.0
           v: 0.0
-          w: 0.0
-
+          w: 0.0

apps/multiphysics/regression_tests/standard_inputs/fracture_reorientation.yaml

@@ -1,10 +1,10 @@
 # num_dims: 3
 
 dynamic_options:
-  time_final: 19.816
-  dt_min: 0.002
-  dt_max: 0.002
-  dt_start: 0.002
+  time_final: 2.0
+  dt_min: 1e-3
+  dt_max: 1e-1
+  dt_start: 1e-2
   cycle_stop: 30000
   rk_num_stages: 1
 
@@ -16,7 +16,7 @@ mesh_options:
 output_options:
   timer_output_level: thorough
   output_file_format: state
-  graphics_time_step: 19.816
+  graphics_time_step: 2.0
   # graphics_iteration_step: 10
   elem_field_outputs:
     - pres
@@ -42,11 +42,11 @@ boundary_conditions:
         type: global
       velocity_model: user_defined
       velocity_bc_global_vars:
-        - 1.0 # reorientation mode flag : 1.0 = enabled; 0.0 = disabled
+        - 1.0          # reorientation mode flag : 1.0 = enabled; 0.0 = disabled
         - 0.3171443868 # omega_y (rotation about x2 axis)
         - 0.3171443868 # omega_z (rotation about x3 axis)
-        - 4.0e-5 # cz opening rate (constant rate of opening for cohesive zone node pairs)
-        - 0.5 # x interface (cm) (x location of interface)
+        - 4.0e-5       # cz opening rate (constant rate of opening for cohesive zone node pairs) [cm/us]
+        - 0.5          # x interface (x location of interface) [cm]
 
   # fracture stress boundary condition
   - boundary_condition:
@@ -55,25 +55,24 @@ boundary_conditions:
         type: global
       stress_model: fracture
       stress_bc_global_vars:
-        - 2.0e-3   #g/cm*us^2 #E_inf (Prony constant term)
-        - 0.1    #a1 (Damage evolution coefficient) dimensionless
-        - 0.25        #n_exp (Damage evolution exponent) dimensionless
-        - 5.0e-3   #cm  #u_n_star (uns: Characteristic length normal)
-        - 5.0e-3   #cm   #u_t_star (uts: Characteristic length tangential)
-        - 1        #num_prony_terms (Filled below: E and tau temrs) dimensionless
-        - 1.8e-2   #g/cm*us^2   #prony_0_E
-        - 2.0      #g/cm*us^3    #prony_0_tau p
-                   #prony_1_E
-                   #prony_1_tau
-
+        - 2.0e-3   # E_inf (Prony constant term) [Mbar]
+        - 0.1      # a1 (Damage evolution coefficient) [dimensionless]
+        - 0.25     # n_exp (Damage evolution exponent) [dimensionless]
+        - 5.0e-3   # u_n_star (uns: Characteristic length normal) [cm]
+        - 5.0e-3   # u_t_star (uts: Characteristic length tangential) [cm]
+        - 1        # num_prony_terms (Filled below: # E and tau temrs)
+        - 1.8e-2   # prony_0_E [Mbar]
+        - 2.0      # prony_0_tau [us]
+                   # prony_1_E (set by num_prony_terms)
+                   # prony_1_tau (set by num_prony_terms)
 materials:
   - material:
       id: 0
       eos_model_type: decoupled
       eos_model: linear_elastic_eos
       eos_global_vars:
-          - 1.4 #  B Bulk modulus g/cm*us^2
-          - 0.4333 # G Shear modulus g/cm*us^2
+          - 1.4 #  B Bulk modulus
+          - 0.4333 # G Shear modulus
           - 1.0 # ref density from Azo materials online
           - 0.001
         #------Strength

apps/multiphysics/regression_tests/standard_inputs/meshes/fracture_reorientation.vtk

@@ -27,4 +27,4 @@ CELLS 2 16
 
 CELL_TYPES 2
 12
-12
+12

apps/multiphysics/regression_tests/standard_results/fracture_mode_1/state/mat_pt_state_t_1.5000e+00.txt

@@ -0,0 +1,4 @@
+# state dump file
+# x  y  z  radius_2D  radius_3D  den  pres  sie  sspd  vol  mass 
+5.000000000000e-01	 5.000000000000e-01	 4.999998549131e-01	 7.071067811865e-01	 8.660253200185e-01	 9.999999040562e-01	 -1.247269410309e-07	 1.000275025963e-10	 1.370304168238e+00	 1.000000095944e+00	 1.000000000000e+00	 
+5.000000000000e-01	 5.000000000000e-01	 1.500000145087e+00	 7.071067811865e-01	 1.658312526414e+00	 9.999999040562e-01	 -1.247269410309e-07	 1.000275025962e-10	 1.370304168238e+00	 1.000000095944e+00	 1.000000000000e+00	 

apps/multiphysics/regression_tests/standard_results/fracture_mode_2/state/mat_pt_state_t_1.5000e+00.txt

@@ -0,0 +1,4 @@
+# state dump file
+# x  y  z  radius_2D  radius_3D  den  pres  sie  sspd  vol  mass 
+4.212111354473e-01	 5.000000000000e-01	 5.001164358502e-01	 6.537727591639e-01	 8.231253063977e-01	 9.993860652087e-01	 -7.981152287101e-04	 1.999720169454e-03	 1.370724934966e+00	 1.000614311939e+00	 1.000000000000e+00	 
+5.787888645527e-01	 5.000000000000e-01	 1.499883564150e+00	 7.648506715237e-01	 1.683641070934e+00	 9.993860652087e-01	 -7.981152287101e-04	 1.999720169454e-03	 1.370724934966e+00	 1.000614311939e+00	 1.000000000000e+00	 

apps/multiphysics/regression_tests/standard_results/fracture_reorientation/state/mat_pt_state_t_2.0000e+00.txt

@@ -0,0 +1,4 @@
+# state dump file
+# x  y  z  radius_2D  radius_3D  den  pres  sie  sspd  vol  mass 
+1.086880098590e-01	 6.955020393104e-01	 2.587737038959e-01	 7.039433003957e-01	 7.500000000000e-01	 1.000000000000e+00	 0.000000000000e+00	 1.000000000000e-10	 1.406319072378e+00	 5.000000000000e-01	 5.000000000000e-01	 
+4.371550909249e-01	 9.329232809760e-01	 -3.417590903634e-02	 1.030267160356e+00	 1.030833844258e+00	 1.000000000000e+00	 0.000000000000e+00	 1.000000000000e-10	 1.406319072378e+00	 5.000000000000e-01	 5.000000000000e-01	 

apps/multiphysics/src/Solvers/SGH_solver_3D/src/fracture.cpp

@@ -54,9 +54,6 @@ void cohesive_zones_t::initialize(swage::Mesh& mesh, State_t& State, const Simul
     // geometric tolerance for determining if nodes are overlapping from dynamic_options.hpp (small = 1e-8)
     const double geom_tol = SimulationParameters.DynamicOptions.small; 
 
-    // update device data before accessing in RUN block
-    State.node.coords.update_device();
-
     // local reference to the array of State.node.coords
     auto node_coords = State.node.coords;
 
@@ -108,6 +105,7 @@ void cohesive_zones_t::initialize(swage::Mesh& mesh, State_t& State, const Simul
 
     // reset counter for second pass
     pair_count.host(0) = 0;
+    // alex to check if this is needed in follow up PR 
     pair_count.update_device();
 
     // device side computation
@@ -158,6 +156,7 @@ void cohesive_zones_t::initialize(swage::Mesh& mesh, State_t& State, const Simul
         geom_tol
     );
     cz_info.update_host();
+
 } // end cohesive_zones_t::initialize
 
 ////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
@@ -240,6 +239,7 @@ void cohesive_zones_t::initialize_fracture_bc(
             prony_params.host(j, 0)     = bc_params.host(6 + 2*j);     // E_j
             prony_params.host(j, 1) = bc_params.host(6 + 2*j + 1); // tau_j
         }
+        // alex to check if this is needed in follow up PR 
         prony_params.update_device();
     } else {
         // allocate minimal array to avoid null issues (debug aid)
@@ -303,6 +303,7 @@ void cohesive_zones_t::initialize_reorientation_mode(
     DCArrayKokkos<int> found_reorient(1, "found_reorient");
     found_reorient.set_values(0); // initialize to zero
     reorient_params.set_values(0.0); // initialize to zero
+    // alex to check if this is needed in follow up PR 
     found_reorient.update_device();
     reorient_params.update_device();
 
@@ -847,6 +848,7 @@ DCArrayKokkos<int> cohesive_zones_t::build_cohesive_zone_info(
     // update host
     cohesive_zone_info.update_host();
     // sync back to device before returning
+    // alex to check if this is needed in follow up PR 
     cohesive_zone_info.update_device();
     return cohesive_zone_info;
 
@@ -1702,9 +1704,12 @@ void cohesive_zones_t::compute_cohesive_zone_nodal_forces(
     const size_t npairs = overlapping_node_gids.dims(0);
     if (npairs == 0) return;
 
-    // ensure mesh connectivity is on device
+    // ensure mesh connectivity and nodal state are current on device
+    // alex to check if this is needed in follow up PR 
     mesh.nodes_in_elem.update_device();
 
+    Kokkos::fence();
+
      // 1) cohesive zone interface orientation (normal at t and t+dt)
     DCArrayKokkos<double> cz_orientation(npairs, 6, "cz_orientation");
     cz_orientation.set_values(0.0);