Replace vendored dkim with dkimpy package#205
Merged
Conversation
- Remove emails/packages/dkim/ (vendored fork of dkimpy 0.5.3) - Use upstream dkimpy package (1.1.8) from PyPI - Add dkimpy to install_requires in setup.py - Update imports in signers.py, exc.py, test_dkim.py - Pass PEM bytes instead of pre-parsed key dict to dkim.sign() - Fix test dnsfunc lambda to accept timeout kwarg - Remove mypy exclusion for emails/packages/ Closes #196
lavr
added a commit
that referenced
this pull request
Mar 31, 2026
- Add dkimpy to requirements/base.txt (was missing after #205) - Remove thread-unsafe monkey-patch of dkim.parse_pem_private_key; PEM parse cost is negligible vs RSA (~0ms vs ~2.5ms per sign) - Add test_dkim_sign_after_error for signer recovery after errors
lavr
added a commit
that referenced
this pull request
Mar 31, 2026
* Add dkimpy to requirements/base.txt, document key parse cost * Add dkimpy to requirements, remove unsafe key-cache monkey-patch - Add dkimpy to requirements/base.txt (was missing after #205) - Remove thread-unsafe monkey-patch of dkim.parse_pem_private_key; PEM parse cost is negligible vs RSA (~0ms vs ~2.5ms per sign) - Add test_dkim_sign_after_error for signer recovery after errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
emails/packages/dkim/— vendored fork of dkimpy 0.5.3 (2015), ~1400 linesdkimpypackage (1.1.8) from PyPI as a direct dependencysigners.py,exc.py,test_dkim.pyemails/packages/Breaking change:
emails.packages.dkimis no longer available. Useimport dkimdirectly.Closes #196
Test plan