Skip to content

Bump ldk-node dependency#72

Merged
tnull merged 2 commits into
lightningdevkit:mainfrom
jkczyz:2025-10-bump-ldk-node
Dec 4, 2025
Merged

Bump ldk-node dependency#72
tnull merged 2 commits into
lightningdevkit:mainfrom
jkczyz:2025-10-bump-ldk-node

Conversation

@jkczyz

@jkczyz jkczyz commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

Bump the ldk-node dependency to support splicing.

@ldk-reviews-bot

ldk-reviews-bot commented Oct 30, 2025 •
edited
Loading

Copy link
Copy Markdown

👋 I see @joostjager was un-assigned.
If you'd like another reviewer assignment, please click here.

@jkczyz jkczyz mentioned this pull request Oct 30, 2025
Merged
@jkczyz jkczyz self-assigned this Oct 30, 2025
@tnull tnull self-requested a review October 30, 2025 17:39
tnull
tnull reviewed Oct 31, 2025
View reviewed changes
Comment thread Cargo.lock

@tnull tnull Oct 31, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems we'll need to check in a separate Cargo-minimal.lock file that we use for MSRV CI.

@jkczyz jkczyz Oct 31, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I usually run cargo with our MSRV, but hadn't done so here. Should I just build using cargo +1.75.0 for any Cargo.lock updates. Not sure what the best practices are.

@tnull tnull Nov 3, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I usually run cargo with our MSRV, but hadn't done so here. Should I just build using cargo +1.75.0 for any Cargo.lock updates. Not sure what the best practices are.

No, I think we want to keep the Cargo.lock on current stable and bump it now and then when we see a requirement. Most projects also check in a separate Cargo-minimal.lock file with the MSRV, see for example https://github.com/rust-bitcoin/rust-bitcoin/blob/master/Cargo-minimal.lock

@benthecarman benthecarman Dec 1, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was going through doing this until I got to the final dep, ldk-node, and realized it's MSRV is now 1.85 so we need to do the same in this project. This luckily solves all our problems

@benthecarman benthecarman force-pushed the 2025-10-bump-ldk-node branch 2 times, most recently from 41f0b8e to 69ebf37 Compare December 1, 2025 20:24
@jkczyz

jkczyz commented Dec 1, 2025

Copy link
Copy Markdown
Contributor Author

Thanks for taking this over @benthecarman. Feel free to squash fixups and clean up commit history as needed.

@benthecarman benthecarman force-pushed the 2025-10-bump-ldk-node branch 2 times, most recently from c4539d7 to 45c1cb9 Compare December 1, 2025 21:20
@jkczyz jkczyz marked this pull request as ready for review December 2, 2025 20:20
jkczyz
jkczyz commented Dec 2, 2025
View reviewed changes

@jkczyz jkczyz left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though it seems I don't have approval power.

@jkczyz jkczyz requested a review from tnull December 2, 2025 20:21
@tnull tnull removed the request for review from joostjager December 3, 2025 08:33
@tnull

tnull commented Dec 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

LGTM, though it seems I don't have approval power.

Strange, it says 'New changes require approval from someone other than the last pusher.', but here Ben is the latest pusher...

tnull
tnull previously approved these changes Dec 3, 2025
View reviewed changes
Comment thread ldk-server/Cargo.toml Outdated
@benthecarman benthecarman force-pushed the 2025-10-bump-ldk-node branch from 45c1cb9 to 551b859 Compare December 3, 2025 18:47
@benthecarman

benthecarman commented Dec 3, 2025

Copy link
Copy Markdown
Collaborator

LGTM, though it seems I don't have approval power.

since its your PR, you can't approve it

@benthecarman benthecarman force-pushed the 2025-10-bump-ldk-node branch from 551b859 to 10280f3 Compare December 3, 2025 21:14
@benthecarman benthecarman mentioned this pull request Dec 3, 2025
Merged
benthecarman and others added 2 commits December 3, 2025 17:19
@benthecarman @jkczyz
Update ldk-node to 0.7.0
a888d9b 
Co-Authored-By: Jeffrey Czyz <jkczyz@gmail.com>
@benthecarman
Update MSRV in CI to 1.85
0e27264 
In ldk-node's update, it bumped its MSRV to 1.85 so we need to do the
same here.
@benthecarman benthecarman force-pushed the 2025-10-bump-ldk-node branch from 10280f3 to 0e27264 Compare December 3, 2025 23:19
@tnull tnull merged commit 281b5e8 into lightningdevkit:main Dec 4, 2025
7 checks passed
rsafier pushed a commit to rsafier/ldk-server that referenced this pull request Apr 20, 2026
@tnull
Merge pull request lightningdevkit#72 from jkczyz/2025-10-bump-ldk-node
8b87399 
Bump `ldk-node` dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benthecarman benthecarman benthecarman left review comments
@tnull tnull tnull approved these changes

Assignees

@jkczyz jkczyz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jkczyz @ldk-reviews-bot @tnull @benthecarman