Delete wgpu room example and redirect to new rust-dev-client#1222
Delete wgpu room example and redirect to new rust-dev-client#12221egoman wants to merge 1 commit into
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔍 Workspace dependencies for GUI/rendering crates may now be unused
The workspace Cargo.toml still declares dependencies for eframe, egui, egui-wgpu, image, wgpu, and winit (lines 85-90), which were marked with the comment # For examples. The wgpu_room example was likely the primary (or sole) consumer of these crates. With its removal, these workspace dependency entries may now be dead weight, pulling in unnecessary entries. Worth checking if any other workspace member still references them — if not, they could be cleaned up to reduce workspace clutter.
(Refers to lines 84-89)
Was this helpful? React with 👍 or 👎 to provide feedback.
| # This example has moved | ||
|
|
||
| The `wgpu_room` example has been broken out into its own repository: | ||
| https://github.com/livekit-examples/rust-dev-client |
There was a problem hiding this comment.
🟡 Main README still advertises the removed example as a local project
The project README still lists the removed example as a working local demo with its old description and link (README.md:168), so users following the link will find only a redirect notice instead of the promised "complete example app."
Impact: Users clicking the example link in the README get a confusing redirect page instead of the described demo app.
Stale reference details
Line 168 of README.md reads:
- wgpu_room: complete example app with video rendering using wgpu and egui.
Since the example code has been deleted and replaced with a README.md that redirects to https://github.com/livekit-examples/rust-dev-client, this entry should either be removed or updated to point to the new repository with an accurate description.
Prompt for agents
The main README.md at line 168 still references wgpu_room as a local example with the description 'complete example app with video rendering using wgpu and egui' and a link to the old tree location. Since the example has been moved to an external repository (https://github.com/livekit-examples/rust-dev-client), this line in README.md should either be removed entirely or updated to point to the new external repository with an accurate description indicating it is now maintained separately.
Was this helpful? React with 👍 or 👎 to provide feedback.
| "examples/screensharing", | ||
| "examples/send_bytes", | ||
| "examples/webhooks", | ||
| "examples/wgpu_room", |
There was a problem hiding this comment.
🟡 No changeset file included for this PR
This PR does not include a changeset file in the .changeset directory (Cargo.toml:37), which is required by the project's contribution rules for every PR.
Impact: The change will not appear in the project's changelog, breaking the documented release process.
Rule and convention details
AGENTS.md states under "Documenting changes":
- Every PR needs a changeset
- Document changes interactively from the CLI with
knope document-changeor create manually in/.changeset
Even though no crate version bump is needed (this only removes an example), the changeset is still required to document the change. A changeset file should be created in .changeset/ describing the removal of the wgpu_room example.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Deletes the
wgpu_roomexample and redirects it to https://github.com/livekit-examples/rust-dev-client