Skip to content

Delete wgpu room example and redirect to new rust-dev-client #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1egoman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Delete wgpu room example and redirect to new rust-dev-client #1222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion Cargo.toml
View file
Open in desktop

@devin-ai-integration devin-ai-integration Bot Jul 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Workspace dependencies for GUI/rendering crates may now be unused

The workspace Cargo.toml still declares dependencies for eframe, egui, egui-wgpu, image, wgpu, and winit (lines 85-90), which were marked with the comment # For examples. The wgpu_room example was likely the primary (or sole) consumer of these crates. With its removal, these workspace dependency entries may now be dead weight, pulling in unnecessary entries. Worth checking if any other workspace member still references them — if not, they could be cleaned up to reduce workspace clutter.

(Refers to lines 84-89)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ members = [
"examples/screensharing",
"examples/send_bytes",
"examples/webhooks",
"examples/wgpu_room",

@devin-ai-integration devin-ai-integration Bot Jul 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 No changeset file included for this PR

This PR does not include a changeset file in the .changeset directory (Cargo.toml:37), which is required by the project's contribution rules for every PR.

Impact: The change will not appear in the project's changelog, breaking the documented release process.

Rule and convention details

AGENTS.md states under "Documenting changes":

  • Every PR needs a changeset
  • Document changes interactively from the CLI with knope document-change or create manually in /.changeset

Even though no crate version bump is needed (this only removes an example), the changeset is still required to document the change. A changeset file should be created in .changeset/ describing the removal of the wgpu_room example.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

]

[workspace.package]
Expand Down
25 changes: 0 additions & 25 deletions examples/wgpu_room/Cargo.toml
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions examples/wgpu_room/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# This example has moved

The `wgpu_room` example has been broken out into its own repository:
https://github.com/livekit-examples/rust-dev-client
Comment on lines +1 to +4

@devin-ai-integration devin-ai-integration Bot Jul 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Main README still advertises the removed example as a local project

The project README still lists the removed example as a working local demo with its old description and link (README.md:168), so users following the link will find only a redirect notice instead of the promised "complete example app."

Impact: Users clicking the example link in the README get a confusing redirect page instead of the described demo app.

Stale reference details

Line 168 of README.md reads:

  • wgpu_room: complete example app with video rendering using wgpu and egui.

Since the example code has been deleted and replaced with a README.md that redirects to https://github.com/livekit-examples/rust-dev-client, this entry should either be removed or updated to point to the new repository with an accurate description.

Prompt for agents 
The main README.md at line 168 still references wgpu_room as a local example with the description 'complete example app with video rendering using wgpu and egui' and a link to the old tree location. Since the example has been moved to an external repository (https://github.com/livekit-examples/rust-dev-client), this line in README.md should either be removed entirely or updated to point to the new external repository with an accurate description indicating it is now maintained separately.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Loading
Loading