Skip to content

refactor: remove redundant localEnsCache and add TTL expiration #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rickstaa wants to merge 3 commits into
base: feat/improve-treasury-votes-caching-behavior
Choose a base branch
from
Open

refactor: remove redundant localEnsCache and add TTL expiration #569

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d397546
refactor: remove redundant localEnsCache and add TTL expiration
rickstaa Mar 3, 2026
7091f26
Update components/Treasury/TreasuryVoteTable/index.tsx
rickstaa Mar 3, 2026
d1d2743
refactor: improve ensCache naming
rickstaa Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions components/Treasury/TreasuryVoteTable/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,25 +13,34 @@ import { MobileVoteCards } from "./Views/MobileVoteTable";
// Module-level cache to avoid repeated ENS lookups across renders/navigations.
// Bound size keeps memory usage predictable during long sessions.
const ENS_CACHE_MAX_ENTRIES = 2000;
const ensCache = new Map<string, string>();
const ENS_CACHE_TTL_MS = 30 * 60 * 1000; // 30 minutes
const ensCache = new Map<
string,
{ nameOrAddress: string; timestamp: number }
>();
const ensLookupInFlight = new Map<string, Promise<string>>();

const getCachedEns = (address: string) => {
if (!ensCache.has(address)) return undefined;
const cached = ensCache.get(address)!;

if (Date.now() - cached.timestamp > ENS_CACHE_TTL_MS) {
ensCache.delete(address);
return undefined;
}

// Refresh insertion order so frequently used addresses stay cached.
ensCache.delete(address);
ensCache.set(address, cached);

return cached;
return cached.nameOrAddress;
};

const setCachedEns = (address: string, ensName: string) => {
if (ensCache.has(address)) {
ensCache.delete(address);
}
ensCache.set(address, ensName);
ensCache.set(address, { nameOrAddress: ensName, timestamp: Date.now() });

if (ensCache.size > ENS_CACHE_MAX_ENTRIES) {
const oldestKey = ensCache.keys().next().value;
Expand Down Expand Up @@ -107,12 +116,11 @@ const useVotes = (proposalId: string) => {
const uniqueVoters = Array.from(
new Set(treasuryVotesData?.treasuryVotes?.map((v) => v.voter.id) ?? [])
);
const localEnsCache: { [address: string]: string } = {};

await Promise.all(
uniqueVoters.map(async (address) => {
try {
localEnsCache[address] = await resolveEnsName(address);
await resolveEnsName(address.toLowerCase());
} catch (e) {
console.warn(`Failed to fetch ENS for ${address}`, e);
}
Expand All @@ -125,7 +133,7 @@ const useVotes = (proposalId: string) => {
.sort((a, b) => b.timestamp - a.timestamp);

const latestEvent = events[0];
const ensName = localEnsCache[vote.voter.id] ?? "";
const ensName = getCachedEns(vote.voter.id.toLowerCase()) ?? "";

return {
...vote,
Expand Down