refactor: remove redundant localEnsCache and add TTL expiration#569
Open
rickstaa wants to merge 3 commits intofeat/improve-treasury-votes-caching-behaviorfrom
Open
refactor: remove redundant localEnsCache and add TTL expiration#569rickstaa wants to merge 3 commits intofeat/improve-treasury-votes-caching-behaviorfrom
rickstaa wants to merge 3 commits intofeat/improve-treasury-votes-caching-behaviorfrom
Conversation
Remove the duplicate localEnsCache object in favor of reading directly from the module-level cache. Add 30-minute TTL expiration so stale ENS names are automatically refreshed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
2 tasks
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
4 tasks
Improve naming of ens cache items to reflect that they can store both a name and address. Co-authored-by: jipstavenuiter <jipstavenuiter@gmail.com>
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
localEnsCacheobject — results are already stored in the module-levelensCache, so we read directly from it viagetCachedEnsinstead of maintaining a duplicateENS_CACHE_TTL_MS) so stale ENS names are automatically refreshed rather than persisting indefinitely within a sessionTest plan
🤖 Generated with Claude Code