feat: use cache-and-network fetch policy for treasury votes#570
Open
rickstaa wants to merge 2 commits intofeat/ens-cache-improvementsfrom
Open
feat: use cache-and-network fetch policy for treasury votes#570rickstaa wants to merge 2 commits intofeat/ens-cache-improvementsfrom
rickstaa wants to merge 2 commits intofeat/ens-cache-improvementsfrom
Conversation
Serve cached vote data instantly on navigation and silently refetch in the background, eliminating unnecessary loading spinners on revisit. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
4 tasks
Add missing return statement in useEffect guard so decorateVotes does not execute when data is not yet loaded. Also only show the error state when there are no cached votes, so a failed background refetch with cache-and-network does not replace already-displayed results. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchPolicy: "cache-and-network"to bothuseTreasuryVotesQueryanduseTreasuryVoteEventsQueryStack
This is part of a stacked PR chain:
feat/improve-treasury-votes-caching-behavior— ENS cachingfeat/ens-cache-improvements— remove redundant localEnsCache + add TTLfeat/apollo-cache-and-network-votes— Apollo fetch policy for vote dataTest plan
🤖 Generated with Claude Code