Skip to content

Modernize install#84

Merged
anacso17 merged 9 commits intomasterfrom
dev/maint/modernize-install
Dec 4, 2025
Merged

Modernize install#84
anacso17 merged 9 commits intomasterfrom
dev/maint/modernize-install

Conversation

@fernandohds564
Copy link
Contributor

@fernandohds564 fernandohds564 commented Jun 5, 2025

see discussion in lnls-sirius/scripts#180

@fernandohds564 fernandohds564 mentioned this pull request Jun 5, 2025
Merged
@fernandohds564
Copy link
Contributor Author

fernandohds564 commented Jun 5, 2025

guys, @anacso17, @xresende, github workflow is not working. Since I'm don't understand it properly, could you help me fix this?

@anacso17
Copy link
Contributor

anacso17 commented Jun 5, 2025 •
edited
Loading

guys, @anacso17, @xresende, github workflow is not working. Since I'm don't understand it properly, could you help me fix this?

Hi @fernandohds564 , @VitorSouzaLNLS solved this problem at https://github.com/lnls-fac/trackcpp/pull/81/files, it is a problem with the way bear is used. Now it needs a -- before make to work. I tested it offline and it worked.

@fernandohds564
Copy link
Contributor Author

fernandohds564 commented Jun 5, 2025

Right! Thanks @anacso17 !

@VitorSouzaLNLS , could you apply the changes suggested by @anacso17 in your PR, so we can merge it?

@VitorSouzaLNLS
Copy link
Contributor

VitorSouzaLNLS commented Jun 6, 2025

Right! Thanks @anacso17 !

@VitorSouzaLNLS , could you apply the changes suggested by @anacso17 in your PR, so we can merge it?

Done! Its ready to be merged. Just waiting for your review/approval (@anacso17, @fernandohds564)

murilobalves
murilobalves reviewed Jun 6, 2025
View reviewed changes
@fernandohds564
Copy link
Contributor Author

fernandohds564 commented Jun 6, 2025

good catch @VitorSouzaLNLS ! I fixed the issue. I don't know why but your comment was deleted from the history...

VitorSouzaLNLS
VitorSouzaLNLS reviewed Jun 6, 2025
View reviewed changes
@VitorSouzaLNLS
Copy link
Contributor

VitorSouzaLNLS commented Jun 6, 2025 •
edited
Loading

good catch @VitorSouzaLNLS ! I fixed the issue. I don't know why but your comment was deleted from the history...

I thought I was writing those comments in "review" mode, but then I realized they were just standalone comments. I deleted them co I could a proper review, but you were quicker @fernandohds564 !

@anacso17 anacso17 merged commit 26e69c1 into master Dec 4, 2025
2 checks passed
@anacso17 anacso17 deleted the dev/maint/modernize-install branch December 4, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@murilobalves murilobalves murilobalves approved these changes

@xresende xresende xresende approved these changes

@anacso17 anacso17 anacso17 approved these changes

@vellosok75 vellosok75 vellosok75 approved these changes

@JeffersonBarrosVieira JeffersonBarrosVieira JeffersonBarrosVieira approved these changes

@Gabrielrezende-asc Gabrielrezende-asc Gabrielrezende-asc approved these changes

@VitorSouzaLNLS VitorSouzaLNLS VitorSouzaLNLS approved these changes

@otavio-silveira otavio-silveira otavio-silveira approved these changes

@arnaldofilho arnaldofilho Awaiting requested review from arnaldofilho

@SergioLordano SergioLordano Awaiting requested review from SergioLordano

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@fernandohds564 @anacso17 @VitorSouzaLNLS @xresende @murilobalves @vellosok75 @JeffersonBarrosVieira @Gabrielrezende-asc @otavio-silveira