Merged
Conversation
This was referenced Jun 5, 2025
murilobalves
approved these changes
Jun 6, 2025
This was referenced Jun 6, 2025
This was referenced Jun 9, 2025
vellosok75
approved these changes
Jun 13, 2025
VitorSouzaLNLS
approved these changes
Jun 13, 2025
JeffersonBarrosVieira
approved these changes
Jun 18, 2025
JeffersonBarrosVieira
approved these changes
Jun 23, 2025
xresende
approved these changes
Jun 24, 2025
…the one from lnls-ima.
…variables as local.
…put option for users to change this default.
Gabrielrezende-asc
approved these changes
Jul 7, 2025
anacso17
approved these changes
Dec 4, 2025
JoaoVitordaSilva174931
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since last year, several changes took place with the Mambaforge project. Now the installer is called Miniforge3 and the initialization method of mamba changed.
Besides, I wasn't able to install the build package with mamba anymore, so I changed the script to install it with pip.
This PR will come together with several other PRs in basically all of our repositories, because since the beggining of this year, pip deprecated the explicit use of the setup.py file as a command line tool, as can be seen in this link and on this github issue.
Now it is highly reccomended to have a pyproject.toml file inside the repositories with a [build-system] table, as discussed here.
Actually, now it is possible to completely remove the setup.py file, since all metadata configurations are supported by the pyproject.toml file, as shown here and here. This link also brings a complete specification of the .toml syntax, which can be helpful to understand the definitions on the PRs I'll link with this one.
Additionally, this link helps us defining all specific setuptools metadata configurations within the pyproject.toml file, making the setup.py completely unnecessary. You guys will notice in my PRs, however, that I kept the file setup.py for now, with duplicated informations. This is because we still need to support python3.6, which still has older versions of pip and setuptools, that does not fully support this new installation mechanism. As soon as the PCs from the control room have their OS updated and we abandon python3.6, I'll make PRs removing the setup.py files from all our repositories.
List of PRs linked with this one.
lnls-fac:
lnls-sirius:
lnls-ima:
lnls-ids:
Guys, @anacso17, I finished making all pull requests related to this PR. It would be nice if we could test a deploy on the control room with these branches. Do you think it is possible to do this?
I just tested the mamba installation script using the new branches for all repositories and it worked well.
@afonsoln also tested the micromamba installation file (.yml) for the hla using the new branches and it also worked.