Closed
Conversation
fernandohds564
requested review from
FernandaMenicucci,
Gabrielrezende-asc,
JeffersonBarrosVieira,
anacso17,
juva143,
lucashfrancisco and
xresende
JeffersonBarrosVieira
approved these changes
Jun 18, 2025
xresende
approved these changes
Jun 25, 2025
Contributor
|
@fernandohds564 , |
Contributor
Author
|
Sure @Gabrielrezende-asc , I agree! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guys, please check the discussion on lnls-sirius/scripts#180.
I tried to make as few changes as possible. If you want not to support python3.6 anymore, it is possible to remove the setup.py file completly.
Besides, I noticed you have two python packages in this same repository,
imaidsandidanalysis, but the old setup.py only installed the imaids. I would recommend you moving the idanalysis to other repository or keep it here, but creating an installation scheme for the idanalysis too.