chore: add netstandard support for Hangfire library#7
chore: add netstandard support for Hangfire library#7kuberto773 wants to merge 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request aims to add netstandard2.1 support to the Hangfire library project, enabling it to target both netstandard2.1 and .NET 10 frameworks for broader compatibility. However, the implementation contains critical syntax errors that will prevent the project from building.
Changes:
- Modified the target framework from net10.0 to multi-targeting netstandard2.1 and net10
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net10.0</TargetFramework> | ||
| <TargetFramework>netstandard2.1;net10</TargetFramework> |
There was a problem hiding this comment.
The property name should be "TargetFrameworks" (plural) when multi-targeting, not "TargetFramework" (singular). When targeting multiple frameworks, MSBuild requires the plural form. This will cause the build to fail as the semicolon-separated list is only valid with TargetFrameworks.
| <TargetFramework>netstandard2.1;net10</TargetFramework> | |
| <TargetFrameworks>netstandard2.1;net10</TargetFrameworks> |
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net10.0</TargetFramework> | ||
| <TargetFramework>netstandard2.1;net10</TargetFramework> |
There was a problem hiding this comment.
The target framework moniker "net10" is non-standard. Based on .NET naming conventions, this should be "net10.0" to properly target .NET 10. The shortened form without the patch version may not be recognized by the build system.
| <TargetFramework>netstandard2.1;net10</TargetFramework> | |
| <TargetFramework>netstandard2.1;net10.0</TargetFramework> |
| <PropertyGroup> | ||
| <TargetFramework>net10.0</TargetFramework> | ||
| <TargetFramework>netstandard2.1;net10</TargetFramework> | ||
| <ImplicitUsings>enable</ImplicitUsings> |
There was a problem hiding this comment.
ImplicitUsings is a C# 10/.NET 6+ feature and is not supported by netstandard2.1, which uses C# 8.0 at most. This will cause compilation errors for the netstandard2.1 target. Consider removing ImplicitUsings or conditionally enabling it only for .NET targets using MSBuild conditions.
No description provided.