Skip to content

chore: add netstandard support for Hangfire library #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kuberto773 wants to merge 1 commit into from
Closed

chore: add netstandard support for Hangfire library #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Madev.Utils.Infrastructure.Hangfire/Madev.Utils.Infrastructure.Hangfire.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net10.0</TargetFramework>
<TargetFramework>netstandard2.1;net10</TargetFramework>
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The property name should be "TargetFrameworks" (plural) when multi-targeting, not "TargetFramework" (singular). When targeting multiple frameworks, MSBuild requires the plural form. This will cause the build to fail as the semicolon-separated list is only valid with TargetFrameworks.

Suggested change
<TargetFramework>netstandard2.1;net10</TargetFramework>
<TargetFrameworks>netstandard2.1;net10</TargetFrameworks>

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The target framework moniker "net10" is non-standard. Based on .NET naming conventions, this should be "net10.0" to properly target .NET 10. The shortened form without the patch version may not be recognized by the build system.

Suggested change
<TargetFramework>netstandard2.1;net10</TargetFramework>
<TargetFramework>netstandard2.1;net10.0</TargetFramework>

Copilot uses AI. Check for mistakes.
<ImplicitUsings>enable</ImplicitUsings>
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ImplicitUsings is a C# 10/.NET 6+ feature and is not supported by netstandard2.1, which uses C# 8.0 at most. This will cause compilation errors for the netstandard2.1 target. Consider removing ImplicitUsings or conditionally enabling it only for .NET targets using MSBuild conditions.

Copilot uses AI. Check for mistakes.
<Nullable>enable</Nullable>

Expand Down
Loading