Skip to content

fix: add descriptive aria labels to interactive controls #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srinidhi-2006-bit wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add descriptive aria labels to interactive controls #1526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/components/DownloadResult.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,11 @@ export default function DownloadResult({ result, onReset, soundOnCompletion, onT
<button
type="button"
onClick={onToggleSound}
aria-label={soundOnCompletion ? "Mute completion sound" : "Unmute completion sound"}
aria-label={
soundOnCompletion
? "Disable export completion sound"
: "Enable export completion sound"
}
className="p-2 rounded-lg border border-[var(--border)] text-[var(--muted)] hover:bg-[var(--bg)] transition-colors"
title={soundOnCompletion ? "Sound on" : "Sound off"}
>
Expand Down Expand Up @@ -138,9 +142,10 @@ export default function DownloadResult({ result, onReset, soundOnCompletion, onT
<a
href={isValid ? result.blobUrl : undefined}
download={isValid ? filename : undefined}
aria-label={`Download video as ${result.format.toUpperCase()}`}
className={cn(
"flex-1 min-w-[10rem] flex items-center justify-center gap-2 py-3 text-sm font-heading font-bold uppercase tracking-wide rounded-lg transition-all",
isValid
isValid
? "bg-[var(--accent)] text-white hover:bg-[var(--accent-hover)] hover:scale-[1.02] active:scale-[0.99] cursor-pointer"
: "bg-[var(--border)] text-[var(--muted)] cursor-not-allowed"
)}
Expand All @@ -151,7 +156,7 @@ export default function DownloadResult({ result, onReset, soundOnCompletion, onT
<Download size={15} aria-hidden="true" />
Download {result.format.toUpperCase()}
</a>
<NativeShareButton
<NativeShareButton
file={result.blob}
fileName={filename}
className="flex-1 min-w-[10rem] py-3 text-sm font-heading font-bold uppercase tracking-wide rounded-lg"
Expand All @@ -168,7 +173,7 @@ export default function DownloadResult({ result, onReset, soundOnCompletion, onT
<button
type="button"
title="Reset and upload a new video"
aria-label="Upload a new video"
aria-label="Reset editor and upload a new video"
onClick={handleReset}
className="flex items-center gap-2 px-4 py-3 border border-[var(--border)] text-[var(--muted)] text-sm rounded-lg hover:border-[var(--accent)] hover:bg-[var(--accent-muted)] hover:text-[var(--text)] transition-colors"
>
Expand Down
1 change: 1 addition & 0 deletions src/components/FileUpload.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ export default function FileUpload({

<button
type="button"
aria-label="Choose a different video file"
onClick={() => inputRef.current?.click()}
className="text-xs font-semibold text-film-600 hover:text-film-700 uppercase tracking-wide"
>
Expand Down
17 changes: 12 additions & 5 deletions src/components/FramingControl.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,17 @@ export default function FramingControl({ recipe, onChange }: Props) {
<button
type="button"
key={mode}
title={mode === "fit" ? "Fit: Adds black bars (letterbox) to fill empty space" : "Fill: Crops the video to fill the entire frame"}
aria-label={
mode === "fit"
? "Fit video within frame with letterboxing"
: "Fill frame by cropping video"
}
aria-pressed={active}
title={
mode === "fit"
? "Fit: Adds black bars (letterbox) to fill empty space"
: "Fill: Crops the video to fill the entire frame"
}
onClick={() => onChange({ framing: mode })}
className={cn(
"flex-1 min-h-[44px] min-w-[44px] flex flex-col items-center justify-center gap-2 py-4 rounded-lg border transition-all duration-150 hover:scale-[1.02] active:scale-[0.98]",
Expand All @@ -29,9 +39,6 @@ export default function FramingControl({ recipe, onChange }: Props) {
)}
>
<Icon size={18} aria-hidden="true" />
<span className="sr-only">
Set framing to {mode === "fit" ? "fit within frame" : "fill frame by cropping"}
</span>
<div className="text-center">
<p className="text-xs font-heading font-semibold uppercase tracking-wider">
{mode === "fit" ? "Fit" : "Fill"}
Expand All @@ -45,4 +52,4 @@ export default function FramingControl({ recipe, onChange }: Props) {
})}
</div>
);
}
}
Loading