Skip to content

feat: add optimized accountsdb crate#14

Open
bmuddha wants to merge 1 commit into
nucleusfrom
accountsdb
Open

feat: add optimized accountsdb crate#14
bmuddha wants to merge 1 commit into
nucleusfrom
accountsdb

Conversation

@bmuddha

@bmuddha bmuddha commented Apr 23, 2026

Copy link
Copy Markdown
Collaborator

What changed

Added the accountsdb crate with persisted and volatile stores, routing logic, snapshot support, and mmap/LMDB-backed storage.

Why

The engine needs one account database that routes mutable and immutable accounts to the correct backend and removes stale copies when an account changes mode.

Closes #6.

Impact

  • Introduces AccountsDB, loaders, iterators, snapshots, backups, and error handling.
  • Adds persisted storage, volatile storage, and the on-disk index layout.
  • Keeps persisted offsets measured in StorageUnit and converts to bytes only at mmap/file boundaries.

Reviewer notes

Snapshot creation requires exclusive write access. The persisted layout and storage-unit arithmetic are the sharp edges to review closely.

Follow-up

ledger and keeper consume this API upstack.

@coderabbitai

coderabbitai Bot commented Apr 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Free

Run ID: e0182446-2e68-4d9c-a048-2c20fe142700

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

bmuddha commented Apr 23, 2026

Copy link
Copy Markdown
Collaborator Author

@bmuddha bmuddha force-pushed the solana-account branch 2 times, most recently from bcb5ccd to 726ddf7 Compare April 23, 2026 13:41
@bmuddha bmuddha force-pushed the accountsdb branch 2 times, most recently from c9feec4 to bb19e9a Compare April 28, 2026 13:23
@bmuddha bmuddha changed the base branch from solana-account to graphite-base/14 May 12, 2026 14:26
@bmuddha bmuddha force-pushed the graphite-base/14 branch from 7501614 to d1b3668 Compare May 12, 2026 14:26
@bmuddha bmuddha changed the base branch from graphite-base/14 to nucleus May 12, 2026 14:26
@bmuddha bmuddha force-pushed the accountsdb branch 2 times, most recently from 013aa2e to cd1401e Compare May 14, 2026 14:46
@bmuddha bmuddha force-pushed the nucleus branch 2 times, most recently from 5f3b4fb to c301271 Compare May 15, 2026 14:52
@bmuddha bmuddha force-pushed the accountsdb branch 2 times, most recently from 46eb345 to 76b9bbf Compare June 19, 2026 11:53
@bmuddha bmuddha force-pushed the nucleus branch 2 times, most recently from 0c537a0 to 4dc2864 Compare June 22, 2026 19:14
@bmuddha bmuddha force-pushed the accountsdb branch 2 times, most recently from 4ecfd50 to b4e46c8 Compare June 23, 2026 14:17
@bmuddha bmuddha force-pushed the accountsdb branch 2 times, most recently from 0e5d509 to 9d2303c Compare June 30, 2026 13:19
@bmuddha bmuddha force-pushed the nucleus branch 2 times, most recently from 814c690 to a6754d6 Compare June 30, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant