Skip to content

feat: add nucleus engine crate#18

Open
bmuddha wants to merge 1 commit into
svmfrom
nucleus
Open

feat: add nucleus engine crate#18
bmuddha wants to merge 1 commit into
svmfrom
nucleus

Conversation

@bmuddha

@bmuddha bmuddha commented May 12, 2026

Copy link
Copy Markdown
Collaborator

What changed

Added the nucleus crate with shared engine primitives, optional Heed integration, byte-size constants, and cooperative shutdown support.

Why

The stack needs a small common crate for engine-wide primitives that should not live inside account storage, ledger, or keeper.

Impact

  • Introduces the shared Slot alias and MB/GB constants.
  • Adds optional heed and shutdown features.
  • Provides ShutdownManager, service handles, cancellation tokens, and termination reasons for engine services.

Reviewer notes

The shutdown manager owns one cancellation token and gives registered services a bounded window to report termination after OS shutdown, internal cancellation, or premature service exit.

Follow-up

ledger and keeper use the shutdown feature upstack.

bmuddha commented May 12, 2026

Copy link
Copy Markdown
Collaborator Author

@bmuddha bmuddha force-pushed the nucleus branch 2 times, most recently from 410f558 to d323e3a Compare May 14, 2026 14:46
@bmuddha bmuddha changed the base branch from solana-account to graphite-base/18 May 28, 2026 13:20
@bmuddha bmuddha force-pushed the graphite-base/18 branch from 2e43191 to fdb2696 Compare May 28, 2026 13:20
@bmuddha bmuddha changed the base branch from graphite-base/18 to svm May 28, 2026 13:20
@bmuddha bmuddha force-pushed the nucleus branch 4 times, most recently from fddd6f0 to c01202f Compare May 28, 2026 14:42
@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Free

Run ID: b2cbb53b-8297-4dd8-b14b-e53d5417d2f9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

@bmuddha bmuddha force-pushed the nucleus branch 2 times, most recently from 02c3fc8 to 5400e0f Compare May 29, 2026 15:49
@bmuddha bmuddha force-pushed the svm branch 2 times, most recently from a03f0fd to d2ebd2c Compare June 1, 2026 15:29
@bmuddha bmuddha force-pushed the nucleus branch 2 times, most recently from 0efccfc to 5b4f905 Compare June 25, 2026 19:52
@bmuddha bmuddha force-pushed the nucleus branch 3 times, most recently from a6754d6 to 9732110 Compare June 30, 2026 21:16
@bmuddha bmuddha force-pushed the svm branch 2 times, most recently from 24b7753 to d8ece3d Compare July 2, 2026 19:39
@bmuddha bmuddha force-pushed the nucleus branch 3 times, most recently from 9d93c24 to 5ea2822 Compare July 3, 2026 22:01
@bmuddha bmuddha force-pushed the svm branch 2 times, most recently from 809ec9f to 72848fc Compare July 6, 2026 09:01
@bmuddha bmuddha force-pushed the nucleus branch 2 times, most recently from 88dd3ba to 88afbef Compare July 6, 2026 12:36
@bmuddha bmuddha marked this pull request as ready for review July 6, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant