Add evidence-aware Sampled Values profile infrastructure#27
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e6b0823c46
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| CompareText("SV_ID", "svID", expected.SvId, observed.SvId, mode, findings); | ||
| CompareText("SV_DATASET", "Dataset reference", expected.DataSetReference, observed.DataSetReference, mode, findings); |
There was a problem hiding this comment.
Preserve exact svID and dataset identifiers
When strict comparison checks svID and dataset reference through CompareText, it also uses the MAC-style normalization that strips -/: and compares case-insensitively. In strict preflight this makes different bindings such as MU-01 vs mu01 or LLN0$Phs-A vs LLN0$PhsA look like an exact match, even though those identifier strings are not MAC addresses and should remain significant. Apply separator-insensitive normalization only to the destination MAC field.
Useful? React with 👍 / 👎.
| if (score >= 70 && evaluatedWeight >= MinimumLikelyWeight) | ||
| return SvProfileConfidence.Likely; | ||
| if (score >= 45 && evaluatedWeight >= MinimumPossibleWeight) | ||
| return SvProfileConfidence.Possible; |
There was a problem hiding this comment.
Return Conflict when any evaluated fact contradicts
A low-weight contradiction can be hidden as Likely or Possible here because those thresholds run before the final conflictWeight > 0 check. For example, if all high-weight fields match but nominal frequency conflicts, conflictWeight is less than matchedWeight and the score stays above 70, so the detector reports Likely despite contradictory evidence; the new output contract says to use Conflict when evaluated facts contradict a definition, and consumers sorting/displaying by confidence can otherwise present a conflicting profile as acceptable.
Useful? React with 👍 / 👎.
Purpose
Implement the standards-neutral profile foundation required before adding verified named Sampled Values profiles.
Engine changes
Confirmed.Tests and coverage
Public repository language
Validation completed
Not included