♻ Support different status revision#118
Merged
ollyhensby merged 6 commits intomainfrom Mar 26, 2025
Merged
Conversation
added 2 commits
March 24, 2025 17:19
This is so that if any dashes are used in the status_revision description, they are not split
In its current setup, the API will reject any new values that are not in the default enumeration. By setting to string, we can bypass this and the validation will be done on the frontend.
ollyhensby
changed the title
ollyhensby
force-pushed
the
support-different-status-revision
branch
from
e5bc004 to
0bec64f
Compare
Contributor
Author
|
Add validation to status_revision so that we check that they're are at least 4 " - "? This at least will provide some validation for the string that is passed |
Contributor
Author
|
Think this is good to go ahead @jgunstone, so going to merge back and implement into digital-schedules. Will show changes when you're back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue relates to this: https://github.com/maxfordham/digital-schedules/issues/322#issuecomment-2747816247
We change the status_revision selection but can't update the API model as this will affect everybody interacting with the API.
So in this PR I have relaxed its type to
strso that any custom status revision can be passed. The frontend will set the enumerations by project and this data will be allowed to be saved to the DB.