Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test-python-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ jobs:

steps:
- uses: actions/checkout@v4
- uses: prefix-dev/setup-pixi@v0.8.1
- uses: prefix-dev/setup-pixi@v0.8.3
with:
manifest-path: pixi.toml
pixi-version: v0.39.0
pixi-version: v0.43.1
cache: true
cache-write: ${{ github.event_name == 'push' && github.ref_name == 'main' }}
- run: |
Expand Down
23 changes: 18 additions & 5 deletions packages/document-issue/src/document_issue/issue.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@

import datetime
from enum import Enum
from typing import Annotated

from pydantic import Field, field_validator, model_validator
from pydantic import AfterValidator, Field, field_validator, model_validator

from document_issue.basemodel import BaseModel
from document_issue.constants import COL_WIDTH
Expand All @@ -12,6 +13,18 @@
description_author = "the person who authored the work."
description_checked_by = "the person who checked the work."

def _check_status_revision(v: str) -> str:
max_dashes = 4
if v.count(" - ") < max_dashes:
msg = "status_revision must be in the format 'code - status description - revision code - revision description - description'"
raise ValueError(msg)
return v

StatusRevision = Annotated[
str,
AfterValidator(_check_status_revision),
]

# TODO: who issued to?
first_status_revision = next(iter(StatusRevisionEnum))

Expand All @@ -24,10 +37,10 @@ class Issue(BaseModel):
title="Date",
json_schema_extra={"column_width": COL_WIDTH},
)
status_revision: StatusRevisionEnum = Field(
first_status_revision,
status_revision: StatusRevision = Field(
first_status_revision.value,
title="Status Revision Selector",
json_schema_extra={"column_width": 1},
json_schema_extra={"enum": [e.value for e in StatusRevisionEnum], "column_width": 1},
)
revision: str = Field(
"",
Expand Down Expand Up @@ -104,7 +117,7 @@ def update_status_revision_fields(self) -> "Issue":
revision_code,
revision_description,
description,
) = status_revision.split(" - ")
) = status_revision.split(" - ", 4)
self.revision = f"{revision_code}{str(self.revision_number).zfill(2)}"
self.status_description = description
return self
Loading
Loading