Update minimum Go version to 1.25#244
Merged
Merged
Conversation
Bump the go directive in go.mod, switch the CI matrix to test 1.25.x and 1.26.x, and update the golangci-lint go target to match. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Go version from 1.24 to 1.25 in both the golangci-lint configuration and the go.mod file. The reviewer suggests changing the go.mod version directive from 1.25.0 to 1.25 to align with standard Go versioning practices and prevent automatic normalization diffs during future go mod tidy runs.
| module github.com/maxmind/MaxMind-DB | ||
|
|
||
| go 1.24.0 | ||
| go 1.25.0 |
There was a problem hiding this comment.
Starting with Go 1.21, the go directive in go.mod should specify the language version (e.g., 1.25) rather than a three-part version with a trailing .0 (e.g., 1.25.0). Running go mod tidy will automatically normalize this to 1.25, which can lead to unexpected diffs in future commits.
Suggested change
| go 1.25.0 | |
| go 1.25 |
oschwald
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump the go directive in go.mod, switch the CI matrix to test 1.25.x and 1.26.x, and update the golangci-lint go target to match.