Skip to content

Update minimum Go version to 1.25 #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oschwald merged 1 commit into from
May 26, 2026
Merged

Update minimum Go version to 1.25 #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
build:
strategy:
matrix:
go-version: [1.24.x, 1.25.x]
go-version: [1.25.x, 1.26.x]
# We don't test on macOS and windows as the database builds aren't
# repeatable there for some reason. As such, tests fail. It'd
# probably be worth looking into this at some point.
Expand Down
2 changes: 1 addition & 1 deletion .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: "2"
run:
# This is needed for precious, which may run multiple instances
# in parallel
go: "1.24"
go: "1.25"
tests: true
allow-parallel-runners: true
linters:
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/maxmind/MaxMind-DB

go 1.24.0
go 1.25.0
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Starting with Go 1.21, the go directive in go.mod should specify the language version (e.g., 1.25) rather than a three-part version with a trailing .0 (e.g., 1.25.0). Running go mod tidy will automatically normalize this to 1.25, which can lead to unexpected diffs in future commits.

Suggested change
go 1.25.0
go 1.25


require (
github.com/maxmind/mmdbwriter v1.2.0
Expand Down
Loading