Skip to content

feat: distinguish PKI decrypt failures - #1022

Open
RCGV1 wants to merge 1 commit into
meshtastic:masterfrom
RCGV1:codex/pki-decrypt-failed
Open

feat: distinguish PKI decrypt failures#1022
RCGV1 wants to merge 1 commit into
meshtastic:masterfrom
RCGV1:codex/pki-decrypt-failed

Conversation

@RCGV1

@RCGV1 RCGV1 commented Jul 26, 2026

Copy link
Copy Markdown
Member

Adds the existing proposed PKI_DECRYPT_FAILED routing error on top of the current protobuf schema.

This lets firmware distinguish an addressed PKI message that cannot authenticate with a stored sender key from an unknown-sender key-exchange request or an ordinary channel failure.

Validated by regenerating the firmware bindings and running the native packet-signing suite against the dependent firmware change.

@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@RCGV1, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 45 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 34bcb0d4-f681-400f-846d-f85b1d651be5

📥 Commits

Reviewing files that changed from the base of the PR and between bfd718f and 57899b8.

📒 Files selected for processing (1)
  • meshtastic/mesh.proto
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants