Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-fixer.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ Read `.github/copilot-instructions.md` and follow all referenced guidelines for
- pytest failures (assertion errors, missing fixtures, import errors)
- bandit security warnings

7. After making fixes, run the checks locally to verify: `uv sync && uv run ruff check . && uv run ruff format --check . && uv run pyright && uv run pytest --cov --cov-fail-under=80 -v`
7. After making fixes, run `make fix` to auto-fix lint and format issues, then run `make check` to verify all checks pass: `make fix && make check`

8. Push the fix commit to the PR branch with a clear commit message like "fix: resolve CI failures (ruff/pyright/pytest)".

Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/copilot-setup-steps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,7 @@ jobs:
uses: github/gh-aw/actions/setup-cli@d688a4a5fa8aa96ad18fa13f0b187c38548a275c # v0.66.1
with:
version: v0.66.1
- name: Install uv
uses: astral-sh/setup-uv@v7
- name: Install Python dependencies
run: uv sync
6 changes: 3 additions & 3 deletions .github/workflows/issue-implementer.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,12 @@ Read `.github/copilot-instructions.md` and follow all referenced guidelines for

Read all files in the repository. Read issue #${{ github.event.inputs.issue_number }} to understand what needs to be fixed. Implement the fix following the spec in the issue, including any testing requirements.

Before committing, run the full CI check suite locally:
Before committing, run `make fix` to auto-fix lint and format issues, then run `make check` to verify all checks pass (lint, type check, security, tests):

```
uv sync && uv run ruff check --fix . && uv run ruff format . && uv run pyright && uv run pytest --cov --cov-fail-under=80 -v
make fix && make check
```

Fix any lint or type errors found by ruff/pyright before committing. Iterate until all checks pass cleanly.
Fix any remaining errors and iterate until `make check` passes cleanly.

Open a pull request with the fix. The PR title should reference the issue number. The PR body MUST include `Closes #${{ github.event.inputs.issue_number }}` so GitHub auto-closes the issue when the PR merges. Include tests as specified in the issue. The PR must NOT be a draft — open it as a regular PR ready for review.
2 changes: 1 addition & 1 deletion .github/workflows/review-responder.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ This workflow addresses unresolved review comments on a pull request.
c. Make the requested fix in the code
d. Reply to the comment thread using `reply_to_pull_request_review_comment` with the comment's `databaseId` as the `comment_id`

5. After addressing all comments, run the CI checks locally to make sure your fixes don't break anything: `uv sync && uv run ruff check --fix . && uv run ruff format . && uv run pyright && uv run pytest --cov --cov-fail-under=80 -v`
5. After addressing all comments, run `make fix` to auto-fix lint and format issues, then run `make check` to verify all checks pass: `make fix && make check`

6. If CI checks fail, fix the issues and re-run until they pass. Do not push broken code.

Expand Down
Loading