fix: resolve memory_store unbound error and RAI condition logic in user_clarification endpoint#843
Merged
Abdul-Microsoft merged 2 commits intopsl-logging-improvementsfrom Mar 10, 2026
Conversation
2 tasks
…gic in user_clarification endpoint Co-authored-by: Abdul-Microsoft <192570837+Abdul-Microsoft@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Improve Application Insights logging and telemetry handling
fix: resolve memory_store unbound error and RAI condition logic in user_clarification endpoint
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs in the
user_clarificationendpoint introduced during telemetry improvements.memory_storeUnboundLocalErrorWhen
plan_idwas provided but the session_id lookup threw (caught byexcept: pass),memory_storewas never assigned — causing anUnboundLocalErroron the subsequentget_current_team()call. Fixed by initializingmemory_storeunconditionally before the plan lookup block.RAI check condition always evaluates to
TrueThis caused the content safety check to run even when no answer was provided.
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.