Skip to content

fix: resolve memory_store unbound error and RAI condition logic in user_clarification endpoint #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abdul-Microsoft merged 2 commits into from
Mar 10, 2026
Merged

fix: resolve memory_store unbound error and RAI condition logic in user_clarification endpoint #843

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2895040
Initial plan
Copilot Mar 10, 2026
c50a139
fix: initialize memory_store unconditionally and fix RAI condition lo…
Copilot Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/backend/v4/api/router.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,9 +620,9 @@ async def user_clarification(

# Attach session_id to span if plan_id is available and capture for events
session_id = None
memory_store = await DatabaseFactory.get_database(user_id=user_id)
if human_feedback.plan_id:
try:
memory_store = await DatabaseFactory.get_database(user_id=user_id)
plan = await memory_store.get_plan_by_plan_id(plan_id=human_feedback.plan_id)
if plan and plan.session_id:
session_id = plan.session_id
Expand All @@ -633,9 +633,6 @@ async def user_clarification(
pass # Don't fail request if span attribute fails

try:
if not human_feedback.plan_id:
memory_store = await DatabaseFactory.get_database(user_id=user_id)
# else: memory_store already initialized above
user_current_team = await memory_store.get_current_team(user_id=user_id)
team_id = None
if user_current_team:
Expand All @@ -654,7 +651,7 @@ async def user_clarification(
# Set the approval in the orchestration config
if user_id and human_feedback.request_id:
# validate rai
if human_feedback.answer is not None or human_feedback.answer != "":
if human_feedback.answer is not None and str(human_feedback.answer).strip() != "":
if not await rai_success(human_feedback.answer, team, memory_store):
event_props = {
"status": "Plan Clarification ",
Expand Down