Skip to content

parse less than token rather than left shift in context of type argum…#26653

Merged
RyanCavanaugh merged 6 commits intomicrosoft:masterfrom
Kingwl:improve_type_arguments_parser_1
Jan 24, 2019
Merged

parse less than token rather than left shift in context of type argum…#26653
RyanCavanaugh merged 6 commits intomicrosoft:masterfrom
Kingwl:improve_type_arguments_parser_1

Conversation

@Kingwl
Copy link
Copy Markdown
Contributor

@Kingwl Kingwl commented Aug 24, 2018 •
edited
Loading

…ents

Fixes #23996

DanielRosenwasser
DanielRosenwasser approved these changes Aug 25, 2018
View reviewed changes
Comment thread tests/baselines/reference/api/typescript.d.ts
scanJsxIdentifier(): SyntaxKind;
scanJsxAttributeValue(): SyntaxKind;
reScanJsxToken(): JsxTokenSyntaxKind;
reScanLessThanToken(): SyntaxKind;
Copy link
Copy Markdown
Member

@DanielRosenwasser DanielRosenwasser Aug 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disgustingly, the corresponding method for a greater-than is called reScanGreaterToken. Not sure if we should be consistent here.

DanielRosenwasser
DanielRosenwasser requested changes Aug 25, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@DanielRosenwasser DanielRosenwasser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually not just type references that this needs to account for - can you add a test case for call type arguments as well?

function foo<T>(x: T) {}

// Both should be equivalent
foo< <T>(x: T) => void>();
foo<<T>(x: T) => void>();

@Kingwl
Copy link
Copy Markdown
Contributor Author

Kingwl commented Sep 4, 2018

☝

RyanCavanaugh
RyanCavanaugh reviewed Sep 6, 2018
View reviewed changes
Comment thread src/compiler/parser.ts Outdated
return currentToken = scanner.reScanTemplateToken();
}

function reScanLesserToken(): SyntaxKind {
Copy link
Copy Markdown
Member

@RyanCavanaugh RyanCavanaugh Sep 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reScanLessThanToken

RyanCavanaugh
RyanCavanaugh requested changes Sep 6, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@RyanCavanaugh RyanCavanaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a rename please

@RyanCavanaugh RyanCavanaugh added this to the TypeScript 3.2 milestone Sep 17, 2018
@Kingwl
Copy link
Copy Markdown
Contributor Author

Kingwl commented Jan 19, 2019

🔼

@RyanCavanaugh RyanCavanaugh merged commit 2f6c65e into microsoft:master Jan 24, 2019
@Kingwl Kingwl deleted the improve_type_arguments_parser_1 branch January 24, 2019 03:21
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser requested changes

@RyanCavanaugh RyanCavanaugh RyanCavanaugh requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

TypeScript 3.3

Development

Successfully merging this pull request may close these issues.

3 participants

@Kingwl @DanielRosenwasser @RyanCavanaugh