-
Notifications
You must be signed in to change notification settings - Fork 13.4k
parse less than token rather than left shift in context of type argum… #26653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
RyanCavanaugh
merged 6 commits into
microsoft:master
from
Kingwl:improve_type_arguments_parser_1
Jan 24, 2019
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
268dbfe
parse less than token rather than left shift in context of type argum…
Kingwl 78444bb
improve test case
Kingwl 0e97ce5
Merge branch 'master' into improve_type_arguments_parser_1
Kingwl f396a2c
rename rescan function
Kingwl e849709
Merge branch 'master' into improve_type_arguments_parser_1
Kingwl e38ac0d
fix api
Kingwl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
tests/baselines/reference/parseGenericArrowRatherThanLeftShift.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| //// [parseGenericArrowRatherThanLeftShift.ts] | ||
| type Bar = ReturnType<<T>(x: T) => number>; | ||
| declare const a: Bar; | ||
|
|
||
| function foo<T>(_x: T) {} | ||
| const b = foo<<T>(x: T) => number>(() => 1); | ||
|
|
||
|
|
||
| //// [parseGenericArrowRatherThanLeftShift.js] | ||
| function foo(_x) { } | ||
| var b = foo(function () { return 1; }); |
25 changes: 25 additions & 0 deletions
25
tests/baselines/reference/parseGenericArrowRatherThanLeftShift.symbols
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| === tests/cases/compiler/parseGenericArrowRatherThanLeftShift.ts === | ||
| type Bar = ReturnType<<T>(x: T) => number>; | ||
| >Bar : Symbol(Bar, Decl(parseGenericArrowRatherThanLeftShift.ts, 0, 0)) | ||
| >ReturnType : Symbol(ReturnType, Decl(lib.es5.d.ts, --, --)) | ||
| >T : Symbol(T, Decl(parseGenericArrowRatherThanLeftShift.ts, 0, 23)) | ||
| >x : Symbol(x, Decl(parseGenericArrowRatherThanLeftShift.ts, 0, 26)) | ||
| >T : Symbol(T, Decl(parseGenericArrowRatherThanLeftShift.ts, 0, 23)) | ||
|
|
||
| declare const a: Bar; | ||
| >a : Symbol(a, Decl(parseGenericArrowRatherThanLeftShift.ts, 1, 13)) | ||
| >Bar : Symbol(Bar, Decl(parseGenericArrowRatherThanLeftShift.ts, 0, 0)) | ||
|
|
||
| function foo<T>(_x: T) {} | ||
| >foo : Symbol(foo, Decl(parseGenericArrowRatherThanLeftShift.ts, 1, 21)) | ||
| >T : Symbol(T, Decl(parseGenericArrowRatherThanLeftShift.ts, 3, 13)) | ||
| >_x : Symbol(_x, Decl(parseGenericArrowRatherThanLeftShift.ts, 3, 16)) | ||
| >T : Symbol(T, Decl(parseGenericArrowRatherThanLeftShift.ts, 3, 13)) | ||
|
|
||
| const b = foo<<T>(x: T) => number>(() => 1); | ||
| >b : Symbol(b, Decl(parseGenericArrowRatherThanLeftShift.ts, 4, 5)) | ||
| >foo : Symbol(foo, Decl(parseGenericArrowRatherThanLeftShift.ts, 1, 21)) | ||
| >T : Symbol(T, Decl(parseGenericArrowRatherThanLeftShift.ts, 4, 15)) | ||
| >x : Symbol(x, Decl(parseGenericArrowRatherThanLeftShift.ts, 4, 18)) | ||
| >T : Symbol(T, Decl(parseGenericArrowRatherThanLeftShift.ts, 4, 15)) | ||
|
|
20 changes: 20 additions & 0 deletions
20
tests/baselines/reference/parseGenericArrowRatherThanLeftShift.types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| === tests/cases/compiler/parseGenericArrowRatherThanLeftShift.ts === | ||
| type Bar = ReturnType<<T>(x: T) => number>; | ||
| >Bar : number | ||
| >x : T | ||
|
|
||
| declare const a: Bar; | ||
| >a : number | ||
|
|
||
| function foo<T>(_x: T) {} | ||
| >foo : <T>(_x: T) => void | ||
| >_x : T | ||
|
|
||
| const b = foo<<T>(x: T) => number>(() => 1); | ||
| >b : void | ||
| >foo<<T>(x: T) => number>(() => 1) : void | ||
| >foo : <T>(_x: T) => void | ||
| >x : T | ||
| >() => 1 : () => number | ||
| >1 : 1 | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| type Bar = ReturnType<<T>(x: T) => number>; | ||
| declare const a: Bar; | ||
|
|
||
| function foo<T>(_x: T) {} | ||
| const b = foo<<T>(x: T) => number>(() => 1); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disgustingly, the corresponding method for a greater-than is called
reScanGreaterToken. Not sure if we should be consistent here.