Skip to content

Suggest adding to tsconfig after installing @types#28211

Merged
sandersn merged 1 commit into
microsoft:masterfrom
ajafff:add-types-error
Oct 30, 2018
Merged

Suggest adding to tsconfig after installing @types#28211
sandersn merged 1 commit into
microsoft:masterfrom
ajafff:add-types-error

Conversation

@ajafff
Copy link
Copy Markdown
Contributor

@ajafff ajafff commented Oct 29, 2018

@sandersn sandersn merged commit 3356879 into microsoft:master Oct 30, 2018
@weswigham
Copy link
Copy Markdown
Member

Small improvement: Have both messages. If a types field exists in the options, use this message, otherwise, use the old one. If a user doesn't have an explicit types option, then they shouldn't need to do anything - they'll be included automatically.

@ajafff ajafff deleted the add-types-error branch October 30, 2018 19:38
@ajafff
Copy link
Copy Markdown
Contributor Author

ajafff commented Oct 30, 2018

@weswigham Sounds good to me. I'll open a follow-up PR.
Should there be a separate message if there is typeRoots in tsconfig?

@weswigham
Copy link
Copy Markdown
Member

Hm; If either of the other messages sound confusing in that context, then I guess so.

ajafff added a commit to ajafff/TypeScript that referenced this pull request Oct 30, 2018
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants