Skip to content

Support string[] and Buffer in stringPlayable block#6976

Open
Copilot wants to merge 2 commits into
masterfrom
copilot/support-string-array-and-buffer
Open

Support string[] and Buffer in stringPlayable block#6976
Copilot wants to merge 2 commits into
masterfrom
copilot/support-string-array-and-buffer

Conversation

Copilot AI commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

stringPlayable only accepted string, while the underlying StringArrayPlayable constructor already handled string | string[] | Buffer. This mismatch prevented callers from passing note arrays or Buffers through the block API.

Changes

  • libs/core/playable.ts: Widened stringPlayable parameter type from string to string | string[] | Buffer — no logic change needed since StringArrayPlayable already dispatches correctly for all three types
  • libs/core/_locales/core-jsdoc-strings.json: Updated the generated locale string to reflect the new accepted types

Example

// Previously only worked with string
music.play(music.stringPlayable("E D G F B A C5 B", 120), music.PlaybackMode.UntilDone);

// Now also works with string[]
music.play(music.stringPlayable(["E", "D", "G", "F"], 120), music.PlaybackMode.UntilDone);

// And Buffer
music.play(music.stringPlayable(melodyBuffer, 120), music.PlaybackMode.UntilDone);

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI changed the title [WIP] Support string array and Buffer in stringPlayable block Support string[] and Buffer in stringPlayable block Jun 26, 2026
Copilot AI requested a review from abchatra June 26, 2026 23:20
@abchatra abchatra marked this pull request as ready for review June 26, 2026 23:42
@abchatra abchatra requested a review from a team June 26, 2026 23:43
@abchatra

Copy link
Copy Markdown
Collaborator

Fixes #6965

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants