Skip to content

Support string[] and Buffer in stringPlayable block #6976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support string[] and Buffer in stringPlayable block #6976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14b3a5e
Initial plan
Copilot Jun 26, 2026
03a5f02
Support string[] and Buffer in stringPlayable block
Copilot Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/core/_locales/core-jsdoc-strings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,7 @@
"music.stopMelody|param|options": "which melody to stop",
"music.stringPlayable": "Play a melody from the melody editor",
"music.stringPlayable|param|bpm": "number in beats per minute dictating how long each note will play",
"music.stringPlayable|param|melody": "string of up to eight notes [C D E F G A B C5] or rests [-] separated by spaces, which will be played one at a time, ex: \"E D G F B A C5 B \"",
"music.stringPlayable|param|melody": "string, string array, or Buffer of notes [C D E F G A B C5] or rests [-], ex: \"E D G F B A C5 B \"",
"music.tempo": "Returns the tempo in beats per minute. Tempo is the speed (bpm = beats per minute) at which notes play. The larger the tempo value, the faster the notes will play.",
"music.tonePlayable": "Plays a tone through pin ``P0`` for the given duration.",
"music.tonePlayable|param|duration": "tone duration in milliseconds (ms)",
Expand Down
4 changes: 2 additions & 2 deletions libs/core/playable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ namespace music {

/**
* Play a melody from the melody editor
* @param melody string of up to eight notes [C D E F G A B C5] or rests [-] separated by spaces, which will be played one at a time, ex: "E D G F B A C5 B "
* @param melody string, string array, or Buffer of notes [C D E F G A B C5] or rests [-], ex: "E D G F B A C5 B "
* @param bpm number in beats per minute dictating how long each note will play
*/
//% blockId="music_string_playable"
Expand All @@ -130,7 +130,7 @@ namespace music {
//% melody.shadow=melody_editor
//% bpm.min=40 bpm.max=500
//% bpm.defl=120
export function stringPlayable(melody: string, bpm: number): Playable {
export function stringPlayable(melody: string | string[] | Buffer, bpm: number): Playable {
return new StringArrayPlayable(melody, bpm);
}

Expand Down
Loading