-
Notifications
You must be signed in to change notification settings - Fork 13
Add nbgv dynamic versioning for releases #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…irj/versioning
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Introduces dynamic versioning via Nerdbank.GitVersioning (NBGV) across the repo, removing hard-coded package versions and configuring builds to derive versions automatically.
Changes:
- Added root
version.jsonto define NBGV versioning rules for main/release branches. - Switched all package
pyproject.tomlfiles todynamic = ["version"]and configured Hatch to source versions from NBGV. - Added
nbgv-pythonto dev dependencies and locked it inuv.lock.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| version.json | Adds NBGV configuration and versioning rules. |
| uv.lock | Adds nbgv-python to the locked dependency set and removes fixed versions for editable workspace packages. |
| pyproject.toml | Adds nbgv-python to the dev dependency group. |
| packages/a2aprotocol/pyproject.toml | Moves to dynamic versioning and configures Hatch to use NBGV. |
| packages/ai/pyproject.toml | Moves to dynamic versioning and configures Hatch to use NBGV. |
| packages/api/pyproject.toml | Moves to dynamic versioning and configures Hatch to use NBGV. |
| packages/apps/pyproject.toml | Moves to dynamic versioning and configures Hatch to use NBGV. |
| packages/botbuilder/pyproject.toml | Moves to dynamic versioning and configures Hatch to use NBGV. |
| packages/cards/pyproject.toml | Moves to dynamic versioning and configures Hatch to use NBGV. |
| packages/common/pyproject.toml | Moves to dynamic versioning and configures Hatch to use NBGV. |
| packages/devtools/pyproject.toml | Moves to dynamic versioning and configures Hatch to use NBGV. |
| packages/graph/pyproject.toml | Moves to dynamic versioning and configures Hatch to use NBGV. |
| packages/mcpplugin/pyproject.toml | Moves to dynamic versioning and configures Hatch to use NBGV. |
| packages/openai/pyproject.toml | Moves to dynamic versioning and configures Hatch to use NBGV. |
| RELEASE.md | Updates release documentation to describe the new NBGV-based release flow. |
Ensures version height bumps when package dependencies change. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add fetch-depth: 0 for full git history (required by nbgv) - Add dotnet and nbgv installation - Remove release.yml (using Azure DevOps pipeline instead) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 16 out of 17 changed files in this pull request and generated 3 comments.
- main: dev versions (not published) - alpha/v2.0.0: alpha releases (published) - release/v2.0.0: stable releases (published) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
@heyitsaamir I've opened a new pull request, #269, to work on those changes. Once the pull request is ready, I'll request review from you. |
corinagum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating RELEASE.md ❤️
How it works:
dev.alpha/v2.0.0branch (it's in Do Not Push - Set up alpha/v2.0.0 branch #268). Create a new PR frommaintoalpha/v2.0.0. Use "merge" commits here.PR Dependency Tree
This tree was auto-generated by Charcoal