Install matrix-specific pytest after test-requirements so pre-release job actually tests pre-release#26027
Draft
eleanorjboyd with Copilot wants to merge 2 commits into
Draft
Install matrix-specific pytest after test-requirements so pre-release job actually tests pre-release#26027eleanorjboyd with Copilot wants to merge 2 commits into
eleanorjboyd with Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix CI configuration for pre-release pytest
Install matrix-specific pytest after test-requirements so pre-release job actually tests pre-release
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pytest@pre-releaseentry in thepython-testsmatrix was not running against pre-release pytest.build/test-requirements.txtpinspytest<8.1(required bypytest-black0.6.0, added in #26009), and it was being installed after the matrix-specific pytest step — silently reverting pre-release/latest pytest back to8.0.2.Changes to
.github/workflows/pr-check.ymltest-requirements.txtruns before the matrix-specific pytest install, letting the matrix version win instead of being overridden.--upgradeto the specific-pytest step so the plainpytestentry actually moves past the<8.1pin to the current stable release (previously also silently held at 8.0.2).pytest --versionstep from the duplicated "Install specific pytest version" to "Print pytest version".The
pytest<8.1pin intest-requirements.txtis retained sopytest-blackcontinues to work; the matrix override now correctly supersedes it for the pre-release and stable jobs.Note: with pre-release pytest now genuinely in effect, the
2496-black-formatterdiscovery test may surface pytest-black incompatibilities on newer pytest — which is the intended signal of the pre-release job.