Skip to content

Install matrix-specific pytest after test-requirements so pre-release job actually tests pre-release #26027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −12
Draft

Install matrix-specific pytest after test-requirements so pre-release job actually tests pre-release #26027

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e414347
Initial plan
Copilot Jul 2, 2026
c44d10b
Reorder pr-check.yml so specific pytest version installs after test-r…
Copilot Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions .github/workflows/pr-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,18 +172,6 @@ jobs:
with:
python-version: ${{ matrix.python }}

- name: Install specific pytest version
if: matrix.pytest-version == 'pytest@pre-release'
run: |
python -m pip install --pre pytest

- name: Install specific pytest version
if: matrix.pytest-version != 'pytest@pre-release'
run: |
python -m pip install "${{ matrix.pytest-version }}"

- name: Install specific pytest version
run: python -m pytest --version
- name: Install base Python requirements
uses: brettcannon/pip-secure-install@92f400e3191171c1858cc0e0d9ac6320173fdb0c # v1.0.0
with:
Expand All @@ -193,6 +181,19 @@ jobs:
- name: Install test requirements
run: python -m pip install --upgrade -r build/test-requirements.txt

# Install the specific pytest version AFTER test-requirements.txt so it is not
# overridden by the `pytest<8.1` pin (needed for pytest-black compatibility).
- name: Install specific pytest version (pre-release)
if: matrix.pytest-version == 'pytest@pre-release'
run: python -m pip install --upgrade --pre pytest

- name: Install specific pytest version
if: matrix.pytest-version != 'pytest@pre-release'
run: python -m pip install --upgrade "${{ matrix.pytest-version }}"

- name: Print pytest version
run: python -m pytest --version

- name: Run Python unit tests
run: python python_files/tests/run_all.py

Expand Down
Loading