Skip to content

More VS Code Onboarding TPI Fixes#309654

Merged
eli-w-king merged 8 commits intomainfrom
eli/exp-ob-revised-2
Apr 14, 2026
Merged

More VS Code Onboarding TPI Fixes#309654
eli-w-king merged 8 commits intomainfrom
eli/exp-ob-revised-2

Conversation

@eli-w-king
Copy link
Copy Markdown
Contributor

@eli-w-king eli-w-king commented Apr 13, 2026 •
edited
Loading

Summary

Multiple fixes for the onboarding walkthrough:

1. Theme preview SVGs not showing in builds

The onboarding theme preview SVGs were not included in the desktop or web build file lists, causing blank theme cards for users running built products (e.g. Insiders).

Added out-build/vs/workbench/contrib/welcomeOnboarding/browser/media/*.svg to:

  • build/gulpfile.vscode.ts (desktop)
  • build/gulpfile.vscode.web.ts (web)

2. "Finish Setup" indicator remains after onboarding sign-in

After completing the onboarding sign-in flow, the status bar still showed "Finish Setup" because the onboarding was not triggering the full chat setup flow (sign-up, extension install, entitlement resolution).

Now triggers workbench.action.chat.triggerSetup with disableChatViewReveal: true and ChatSetupStrategy.DefaultSetup after sign-in, running the setup in the background without showing dialogs or revealing the chat panel.

3. Extension Marketplace keybinding tip

Added Cmd+Shift+X (or Ctrl+Shift+X) keybinding tip to the Extensions step subtitle so users know how to browse the full Extension Marketplace after onboarding.

4. Screenreader accessibility

  • Extension install buttons now have aria-label with the extension name (e.g. "Install Python") instead of just "Install"
  • Feature cards (Local, Cloud, Copilot CLI, Inline Suggestions) are now tabbable with role="group" and aria-label
  • ARIA alerts fire on theme selection, keymap selection, extension install, and AI preference changes

Fixes: #309380
Fixes: #309382
Fixes: #309521
Fixes: #309525
Fixes: #309529
Fixes: #309617

@eli-w-king
onboarding: include theme preview SVGs in build output
4fe2ba8 
The theme preview SVGs were not bundled in desktop or web builds,
causing blank theme cards for users running built products.

Fixes #309380
Copilot AI review requested due to automatic review settings April 13, 2026 22:37
@github-actions

This comment was marked as outdated.

Sign in to view
Copilot AI reviewed Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to ensure the Welcome Onboarding theme preview SVG assets are included in packaged desktop and web build outputs, preventing blank theme cards in built products.

Changes:

  • Added out-build/vs/workbench/contrib/welcomeOnboarding/browser/media/*.svg to the desktop resource include list.
  • Added out-build/vs/workbench/contrib/welcomeOnboarding/browser/media/*.svg to the web resource include list.
Show a summary per file
File Description
build/gulpfile.vscode.web.ts Adds onboarding theme preview SVGs to the web build resource include globs.
build/gulpfile.vscode.ts Adds onboarding theme preview SVGs to the desktop build resource include globs.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 2

build/gulpfile.vscode.web.ts
Comment on lines 75 to +77
// Welcome
'out-build/vs/workbench/contrib/welcomeGettingStarted/common/media/**/*.{svg,png}',
'out-build/vs/workbench/contrib/welcomeOnboarding/browser/media/*.svg',
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This include only affects the legacy optimize.bundleTask path. The vscode-web* gulp tasks in this file run the esbuild bundler (build/next/index.ts bundle), which uses its own webResourcePatterns list and currently does not include vs/workbench/contrib/welcomeOnboarding/browser/media/*.svg, so the SVGs will still be missing from web build outputs when using the esbuild pipeline. Please also add the corresponding resource pattern(s) in build/next/index.ts (web + server-web, and likely desktop as well) so both build pipelines ship these SVGs.

Copilot uses AI. Check for mistakes.
build/gulpfile.vscode.ts
Comment on lines 98 to +100
// Welcome
'out-build/vs/workbench/contrib/welcomeGettingStarted/common/media/**/*.{svg,png}',
'out-build/vs/workbench/contrib/welcomeOnboarding/browser/media/*.svg',
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this glob fixes the legacy bundle-vscode/minify-vscode pipeline, but the esbuild pipeline (build/next/index.ts bundle) has its own curated resource lists (desktopResourcePatterns, etc.) and currently does not include vs/workbench/contrib/welcomeOnboarding/browser/media/*.svg. If useEsbuildTranspile is enabled for packaging, these SVGs will still be missing. Please mirror this addition in build/next/index.ts so both build pipelines include the onboarding theme preview SVGs.

Copilot uses AI. Check for mistakes.
@eli-w-king
onboarding: trigger chat setup after sign-in to resolve entitlements
1c425f7 
After the user signs in through the onboarding walkthrough, trigger the
full chat setup flow in the background (sign-up, extension install,
entitlement resolution) so the 'Finish Setup' status bar indicator
is resolved by the time onboarding completes.

Uses disableChatViewReveal and DefaultSetup strategy to avoid
showing dialogs or popping the chat panel during onboarding.

Fixes #309529
@eli-w-king eli-w-king changed the title onboarding: include theme preview SVGs in build output onboarding: include theme preview SVGs and resolve entitlements after sign-in Apr 13, 2026
@eli-w-king eli-w-king changed the title onboarding: include theme preview SVGs and resolve entitlements after sign-in VS Code Onboarding TPI Fixes Apr 13, 2026
@eli-w-king
onboarding: add Extension Marketplace keybinding tip to extensions step
84c57e3 
Shows Cmd+Shift+X (Ctrl+Shift+X on Windows/Linux) in the extensions
step subtitle so users know how to browse the full marketplace.

Fixes #309617
@eli-w-king
Merge branch 'main' into eli/exp-ob-revised-2
973d605
@eli-w-king eli-w-king added this to the 1.116.0 milestone Apr 13, 2026
@eli-w-king eli-w-king changed the title VS Code Onboarding TPI Fixes More VS Code Onboarding TPI Fixes Apr 13, 2026
@eli-w-king
onboarding: screenreader accessibility fixes
c6b7d69 
- Add aria-label to extension install buttons with extension name (#309382)
- Make feature cards (Local, Cloud, CLI, Inline) tabbable with role/aria-label (#309525)
- Add ARIA alerts on theme, keymap, extension install, and AI preference actions (#309521)

Fixes #309382
Fixes #309521
Fixes #309525
@eli-w-king
Merge branch 'main' into eli/exp-ob-revised-2
5d89aa1
@eli-w-king eli-w-king marked this pull request as ready for review April 13, 2026 23:35
@austindyoung austindyoung mentioned this pull request Apr 13, 2026
Open
@eli-w-king eli-w-king mentioned this pull request Apr 13, 2026
Closed
@eli-w-king eli-w-king enabled auto-merge April 13, 2026 23:50
joshspicer
joshspicer requested changes Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@joshspicer joshspicer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think https://github.com/microsoft/vscode/pull/309654/changes#r3076224700 is a valid comment

@eli-w-king eli-w-king merged commit 28b5573 into main Apr 14, 2026
26 checks passed
@eli-w-king eli-w-king deleted the eli/exp-ob-revised-2 branch April 14, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment