github-authentication: skip education.github.com check for EMU accounts#327379
Open
brignano wants to merge 1 commit into
Open
github-authentication: skip education.github.com check for EMU accounts#327379brignano wants to merge 1 commit into
brignano wants to merge 1 commit into
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @TylerLeonhardtMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Skips unnecessary GitHub Education requests for Enterprise Managed User accounts while preserving existing telemetry.
Changes:
- Detects managed accounts before the EDU lookup.
- Reports
isEdu: 'none'without fetching for managed accounts. - Reuses the detection result for telemetry.
Author
|
@microsoft-github-policy-service agree |
brignano
force-pushed
the
claude/emu-education-check-skip-f9e43c
branch
2 times, most recently
from
July 24, 2026 20:54
3bd5c8a to
2426026
Compare
Managed (EMU) accounts can't access the education.github.com endpoint, so evaluate the EMU heuristic up front and skip the fetch entirely for them, setting edu to 'none'. Telemetry schema is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
brignano
force-pushed
the
claude/emu-education-check-skip-f9e43c
branch
from
July 24, 2026 21:04
2426026 to
6c5ccc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #327377
Skips the optional
education.github.comEDU lookup for managed (EMU) accounts, which can't reach that endpoint anyway.Before: every session load — including EMU accounts — fires a network request to
education.github.com/api/user.After: EMU-style accounts short-circuit before the fetch, set
edu = 'none', and log that the check was skipped. Non-EMU accounts are unaffected. Telemetry schema is unchanged (isEdu,isManaged— same names, same__GDPR__block).Testing: type-checks cleanly against the extension's
tsconfig(TypeScript 6,--noEmit, 0 errors); hygiene clean (tabs, no trailing whitespace); non-EMU sign-in path unchanged; an EMU login short-circuits before the fetch.