Skip to content

github-authentication: skip education.github.com check for EMU accounts #327379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brignano wants to merge 1 commit into
base: main
Choose a base branch
from
+35 −25
Open

github-authentication: skip education.github.com check for EMU accounts #327379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 35 additions & 25 deletions extensions/github-authentication/src/githubServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,32 +281,43 @@ export class GitHubServer implements IGitHubServer {
private async checkUserDetails(session: vscode.AuthenticationSession): Promise<void> {
let edu: string | undefined;

try {
const result = await fetching('https://education.github.com/api/user', {
logger: this._logger,
retryFallbacks: true,
expectJSON: true,
headers: {
Authorization: `token ${session.accessToken}`,
'faculty-check-preview': 'true',
'User-Agent': `${vscode.env.appName} (${vscode.env.appHost})`
}
});
// The account label is the GitHub login. Normal logins only allow alphanumerics and
// hyphens, but Enterprise Managed User (EMU) accounts are provisioned as
// `<idp-username>_<shortcode>`, so an underscore in the login means a managed account.
const isManaged = session.account.label.includes('_');

if (isManaged) {
// EMU accounts can't access the education.github.com endpoint, so skip the fetch entirely.
this._logger.info('Skipping optional EDU details check for a managed account.');
edu = 'none';
} else {
try {
const result = await fetching('https://education.github.com/api/user', {
logger: this._logger,
retryFallbacks: true,
expectJSON: true,
headers: {
Authorization: `token ${session.accessToken}`,
'faculty-check-preview': 'true',
'User-Agent': `${vscode.env.appName} (${vscode.env.appHost})`
}
});

if (result.ok) {
const json: { student: boolean; faculty: boolean } = await result.json();
edu = json.student
? 'student'
: json.faculty
? 'faculty'
: 'none';
} else {
this._logger.info(`Unable to resolve optional EDU details. Status: ${result.status} ${result.statusText}`);
if (result.ok) {
const json: { student: boolean; faculty: boolean } = await result.json();
edu = json.student
? 'student'
: json.faculty
? 'faculty'
: 'none';
} else {
this._logger.info(`Unable to resolve optional EDU details. Status: ${result.status} ${result.statusText}`);
edu = 'unknown';
}
} catch (e) {
this._logger.info(`Unable to resolve optional EDU details. Error: ${e}`);
edu = 'unknown';
}
} catch (e) {
this._logger.info(`Unable to resolve optional EDU details. Error: ${e}`);
edu = 'unknown';
}

/* __GDPR__
Expand All @@ -318,8 +329,7 @@ export class GitHubServer implements IGitHubServer {
*/
this._telemetryReporter.sendTelemetryEvent('session', {
isEdu: edu,
// Apparently, this is how you tell if a user is an EMU...
isManaged: session.account.label.includes('_') ? 'true' : 'false'
isManaged: isManaged ? 'true' : 'false'
});
}

Expand Down