Isolate Graph authentication assembly loading (#3632)#3633
Open
ramsessanchez wants to merge 1 commit into
Open
Isolate Graph authentication assembly loading (#3632)#3633ramsessanchez wants to merge 1 commit into
ramsessanchez wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Microsoft.Graph.Authentication PowerShell module wrapper to load the authentication binary (Microsoft.Graph.Authentication.dll) into a dedicated AssemblyLoadContext on PowerShell Core, improving dependency isolation for Microsoft 365 module interop scenarios while keeping Windows PowerShell/Desktop behavior unchanged.
Changes:
- Load
Microsoft.Graph.Authentication.dllvia a namedAssemblyLoadContexton PowerShell Core and add a managed dependency resolver for that context. - Stop generating
NestedModulesentries for the authentication DLLs so the script module controls when/how the binary loads. - Add Pester coverage to validate the root assembly and worker-thread dependency resolution are outside
AssemblyLoadContext.Defaulton PowerShell Core.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Authentication/Authentication/Microsoft.Graph.Authentication.psm1 | Introduces custom ALC loading, dependency resolver registration, and updated export/alias logic. |
| src/Authentication/Authentication/test/Microsoft.Graph.Authentication.Tests.ps1 | Adds import-time tests to assert isolated ALC loading and worker-thread dependency resolution. |
| src/Authentication/Authentication/build-module.ps1 | Removes generated NestedModules update so the wrapper controls assembly load context selection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+65
to
+78
|
|
||
| foreach (string dependencyFolder in dependencyFolders) | ||
| { | ||
| if (string.IsNullOrWhiteSpace(dependencyFolder) || !Directory.Exists(dependencyFolder)) | ||
| { | ||
| continue; | ||
| } | ||
|
|
||
| string dependencyPath = Path.Combine(dependencyFolder, assemblyName.Name + ".dll"); | ||
| if (File.Exists(dependencyPath)) | ||
| { | ||
| return context.LoadFromAssemblyPath(Path.GetFullPath(dependencyPath)); | ||
| } | ||
| } |
Comment on lines
+93
to
+95
| if ($PSEdition -ne 'Core' -or -not ('System.Runtime.Loader.AssemblyLoadContext' -as [type])) { | ||
| return Import-Module -Name $ModulePath -PassThru | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full Description available here: #3632