Address auth ALC review comments#3635
Open
PrzemyslawKlys wants to merge 1 commit into
Open
Conversation
cd5a7e7 to
0e5d653
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
assemblyName.Namebefore using it in the managed ALC resolver.Import-Module -LiteralPathfor the Desktop/no-ALC fallback path.Azure.Coreis absent fromAssemblyLoadContext.Default.Why
This addresses the inline Copilot review comments from #3633 and the earlier test flakiness concern from #3632.
The production resolver should treat a missing assembly name as an ordinary resolution miss and return
null. The Desktop fallback should import the exact DLL path instead of allowing wildcard interpretation. The test only needs to prove that the dependency resolved by the worker thread lands in the same non-default Graph authentication ALC; it should not fail merely because another test loadedAzure.Corein the default context.Validation
pwsh -NoProfile -Command 'Invoke-Pester .\src\Authentication\Authentication\test\Microsoft.Graph.Authentication.Tests.ps1 -Output Detailed'Microsoft.Graph.Authentication.psm1git diff --checkOther links