Fix adjustForDST to use actual DST savings#47
Open
guillerodriguez wants to merge 1 commit intomikereedell:masterfrom
Open
Fix adjustForDST to use actual DST savings#47guillerodriguez wants to merge 1 commit intomikereedell:masterfrom
guillerodriguez wants to merge 1 commit intomikereedell:masterfrom
Conversation
SolarEventCalculator.adjustForDST() always adds 1 hour during DST,
but some timezones have different DST savings (for example, 2 hours
in Antarctica/Troll, or 30 minutes in Australia/Lord_Howe).
Also, some timezones have changed their DST rules historically.
So, compute DST savings as:
TimeZone.getOffset(millis) - TimeZone.getRawOffset()
which returns the actual value for the given timestamp, instead of
TimeZone.getDSTSavings(), which would return the timezone's "current"
or "default" DST savings.
Fixes mikereedell#18
Author
|
Note: I added a test case to reproduce the original bug and validate the fix. Since adjustForDST() is currently private, the test exercises the bug indirectly through SunriseSunsetCalculator's public API. An alternative would be to make adjustForDST() package-private and have the test code call it directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SolarEventCalculator.adjustForDST() always adds 1 hour during DST, but some timezones have different DST savings (for example, 2 hours in Antarctica/Troll, or 30 minutes in Australia/Lord_Howe).
Also, some timezones have changed their DST rules historically. So, compute DST savings as:
which returns the actual value for the given timestamp, instead of TimeZone.getDSTSavings(), which would return the timezone's "current" or "default" DST savings.
Fixes: #18